linux-next: build failure after merge of the leds-lj tree

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
  889 |         vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
      |               ^~~~~~~~~

Caused by commit

  55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")

I have used the leds-lj tree from next-20230317 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[ChiYuan Huang]

On Mon, Mar 20, 2023 at 11:48:16AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
>   889 |         vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
>       |               ^~~~~~~~~
> 
> Caused by commit
> 
>   55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> 
> I have used the leds-lj tree from next-20230317 for today.
>
Already sent the patch.
https://lore.kernel.org/lkml/1679067760-19098-1-git-send-email-cy_huang@richtek.com/ 

Wait for reviewing.
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Hi all,

On Mon, 20 Mar 2023 11:48:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
>   889 |         vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
>       |               ^~~~~~~~~
> 
> Caused by commit
> 
>   55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> 
> I have used the leds-lj tree from next-20230317 for today.

I am still getting this build failure.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Wed, 22 Mar 2023, Stephen Rothwell wrote:

> Hi all,
>
> On Mon, 20 Mar 2023 11:48:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the leds-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
> > drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> >   889 |         vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> >       |               ^~~~~~~~~
> >
> > Caused by commit
> >
> >   55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> >
> > I have used the leds-lj tree from next-20230317 for today.
>
> I am still getting this build failure.

Fix applied and pushed.  Thanks for the reminder.

--
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the leds-lj tree

[Marek Vasut]

On 8/9/23 05:17, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> FATAL: modpost: drivers/leds/leds-pca995x: sizeof(struct i2c_device_id)=32 is not a modulo of the size of section __mod_i2c__<identifier>_device_table=600.
> Fix definition of struct i2c_device_id in mod_devicetable.h
> 
> Presumably caused by commit
> 
>    ee4e80b2962e ("leds: pca995x: Add support for PCA995X chips")
> 
> I have reverted that commit for today.

Ah doh, the fix is trivial, proper patch is coming in a bit.

diff --git a/drivers/leds/leds-pca995x.c b/drivers/leds/leds-pca995x.c
index 3ac99a433fcd2..78215dff14997 100644
--- a/drivers/leds/leds-pca995x.c
+++ b/drivers/leds/leds-pca995x.c
@@ -187,7 +187,7 @@ static const struct of_device_id pca995x_of_match[] = {
         { .compatible = "nxp,pca9955b", .data = (void *)PCA995X_TYPE_B },
         {},
  };
-MODULE_DEVICE_TABLE(i2c, pca995x_of_match);
+MODULE_DEVICE_TABLE(of, pca995x_of_match);

  static struct i2c_driver pca995x_driver = {
         .driver = {

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/rgb/leds-qcom-lpg.c:17:10: fatal error: linux/soc/qcom/qcom-pbs.h: No such file or directory
   17 | #include <linux/soc/qcom/qcom-pbs.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  8148c8234e10 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")

I have used the leds-lj tree from next-20240125 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Mon, 29 Jan 2024, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/rgb/leds-qcom-lpg.c:17:10: fatal error: linux/soc/qcom/qcom-pbs.h: No such file or directory
>    17 | #include <linux/soc/qcom/qcom-pbs.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   8148c8234e10 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")

I'm holding out for a little while:

  https://lore.kernel.org/r/20240125130432.GG74950@google.com

> I have used the leds-lj tree from next-20240125 for today.

Thanks.  Please keep doing this for "a little while". :)

-- 
Lee Jones [李琼斯]

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 9620 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-lp5521.c: In function 'lp5521_selftest':
drivers/leds/leds-lp5521.c:189:33: error: macro "guard" passed 2 arguments, but takes just 1
  189 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp5521.c:12:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5521.c:189:9: error: 'guard' undeclared (first use in this function)
  189 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5521.c:189:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp5523.c: In function 'lp5523_selftest':
drivers/leds/leds-lp5523.c:192:33: error: macro "guard" passed 2 arguments, but takes just 1
  192 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp5523.c:12:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5523.c:192:9: error: 'guard' undeclared (first use in this function)
  192 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5523.c:192:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp5562.c: In function 'lp5562_led_brightness':
drivers/leds/leds-lp5562.c:175:33: error: macro "guard" passed 2 arguments, but takes just 1
  175 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp5562.c:10:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5562.c:175:9: error: 'guard' undeclared (first use in this function)
  175 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5562.c:175:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp5562.c: In function 'lp5562_store_pattern':
drivers/leds/leds-lp5562.c:272:33: error: macro "guard" passed 2 arguments, but takes just 1
  272 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5562.c:272:9: error: 'guard' undeclared (first use in this function)
  272 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5562.c: In function 'lp5562_store_engine_mux':
drivers/leds/leds-lp5562.c:324:33: error: macro "guard" passed 2 arguments, but takes just 1
  324 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5562.c:324:9: error: 'guard' undeclared (first use in this function)
  324 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_led_brightness':
drivers/leds/leds-lp55xx-common.c:276:33: error: macro "guard" passed 2 arguments, but takes just 1
  276 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp55xx-common.c:13:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:276:9: error: 'guard' undeclared (first use in this function)
  276 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c:276:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_multicolor_brightness':
drivers/leds/leds-lp55xx-common.c:291:33: error: macro "guard" passed 2 arguments, but takes just 1
  291 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:291:9: error: 'guard' undeclared (first use in this function)
  291 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'led_current_store':
drivers/leds/leds-lp55xx-common.c:409:33: error: macro "guard" passed 2 arguments, but takes just 1
  409 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:409:9: error: 'guard' undeclared (first use in this function)
  409 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'run_engine_store':
drivers/leds/leds-lp55xx-common.c:637:33: error: macro "guard" passed 2 arguments, but takes just 1
  637 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:637:9: error: 'guard' undeclared (first use in this function)
  637 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_engine_mode':
drivers/leds/leds-lp55xx-common.c:676:33: error: macro "guard" passed 2 arguments, but takes just 1
  676 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:676:9: error: 'guard' undeclared (first use in this function)
  676 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_engine_load':
drivers/leds/leds-lp55xx-common.c:704:33: error: macro "guard" passed 2 arguments, but takes just 1
  704 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:704:9: error: 'guard' undeclared (first use in this function)
  704 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_engine_leds':
drivers/leds/leds-lp55xx-common.c:803:33: error: macro "guard" passed 2 arguments, but takes just 1
  803 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:803:9: error: 'guard' undeclared (first use in this function)
  803 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c:798:17: error: unused variable 'ret' [-Werror=unused-variable]
  798 |         ssize_t ret;
      |                 ^~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_show_master_fader':
drivers/leds/leds-lp55xx-common.c:827:33: error: macro "guard" passed 2 arguments, but takes just 1
  827 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:827:9: error: 'guard' undeclared (first use in this function)
  827 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_master_fader':
drivers/leds/leds-lp55xx-common.c:851:33: error: macro "guard" passed 2 arguments, but takes just 1
  851 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:851:9: error: 'guard' undeclared (first use in this function)
  851 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_show_master_fader_leds':
drivers/leds/leds-lp55xx-common.c:870:33: error: macro "guard" passed 2 arguments, but takes just 1
  870 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:870:9: error: 'guard' undeclared (first use in this function)
  870 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_master_fader_leds':
drivers/leds/leds-lp55xx-common.c:901:33: error: macro "guard" passed 2 arguments, but takes just 1
  901 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:901:9: error: 'guard' undeclared (first use in this function)
  901 |         guard(mutex, &chip->lock);
      |         ^~~~~
cc1: all warnings being treated as errors

Caused by commit

  efd0d1cbb8c5 ("leds: leds-lp55xx: Convert mutex lock/unlock to guard API")

I have used the led-lj tree from next-20240709 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Wed, 10 Jul 2024, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/leds-lp5521.c: In function 'lp5521_selftest':
> drivers/leds/leds-lp5521.c:189:33: error: macro "guard" passed 2 arguments, but takes just 1
>   189 |         guard(mutex, &chip->lock);

On it.  Thanks for the heads-up.

https://lore.kernel.org/all/20240710071050.GF501857@google.com/

-- 
Lee Jones [李琼斯]

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3312 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/leds/leds-lp5569.c:11:
drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  204 |                           chip, LP5569_REG_STATUS, &val);
      |                                                    ^~~~
      |                                                    |
      |                                                    int *
include/linux/iopoll.h:46:28: note: in definition of macro 'read_poll_timeout'
   46 |                 (val) = op(args); \
      |                            ^~~~
In file included from drivers/leds/leds-lp5569.c:20:
drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
  229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
      |                                                          ~~~~^~~
drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
  204 |                           chip, LP5569_REG_STATUS, &val);
      |                                                    ^~~~
      |                                                    |
      |                                                    int *
include/linux/iopoll.h:51:36: note: in definition of macro 'read_poll_timeout'
   51 |                         (val) = op(args); \
      |                                    ^~~~
drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
  229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
      |                                                          ~~~~^~~
cc1: all warnings being treated as errors

Caused by commit

  d9cc80b1c9b4 ("leds: leds-lp5569: Enable chip after chip configuration")

I have applied the folloing patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 12 Jul 2024 14:40:23 +1000
Subject: [PATCH] fixup for "leds: leds-lp5569: Enable chip after chip configuration"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/leds/leds-lp5569.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-lp5569.c b/drivers/leds/leds-lp5569.c
index 52fb83f35bb7..623030f2f5ac 100644
--- a/drivers/leds/leds-lp5569.c
+++ b/drivers/leds/leds-lp5569.c
@@ -173,6 +173,7 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip)
 {
 	int ret;
 	int val;
+	u8 u8val;
 
 	val = LP5569_DEFAULT_CONFIG;
 	val |= FIELD_PREP(LP5569_CP_MODE_MASK, chip->pdata->charge_pump_mode);
@@ -201,7 +202,7 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip)
 
 	read_poll_timeout(lp55xx_read, ret, !(val & LP5569_STARTUP_BUSY),
 			  LP5569_STARTUP_SLEEP, LP5569_STARTUP_SLEEP * 10, false,
-			  chip, LP5569_REG_STATUS, &val);
+			  chip, LP5569_REG_STATUS, &u8val);
 
 	return lp5569_init_program_engine(chip);
 }
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

Christian,

> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/leds/leds-lp5569.c:11:
> drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
> drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   204 |                           chip, LP5569_REG_STATUS, &val);
>       |                                                    ^~~~
>       |                                                    |
>       |                                                    int *

The only reason for applying this set this late in the cycle was that
they appeared to be fixes for other brokenness.

This is the second set that you've submitted in recent days that has
caused build breakages.  Something is wrong with your current
development practices.  Are you able to identify and rectify these
issue(s) before a lose trust in your submissions?

-- 
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the leds-lj tree

[Christian Marangi]

On Fri, Jul 12, 2024 at 08:31:39AM +0100, Lee Jones wrote:
> Christian,
> 
> > Hi all,
> > 
> > After merging the leds-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > In file included from drivers/leds/leds-lp5569.c:11:
> > drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
> > drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   204 |                           chip, LP5569_REG_STATUS, &val);
> >       |                                                    ^~~~
> >       |                                                    |
> >       |                                                    int *
> 
> The only reason for applying this set this late in the cycle was that
> they appeared to be fixes for other brokenness.
> 
> This is the second set that you've submitted in recent days that has
> caused build breakages.  Something is wrong with your current
> development practices.  Are you able to identify and rectify these
> issue(s) before a lose trust in your submissions?
>

Yes, I identified the problem and the config was silently getting
disabled and hiding all the errors/warning. Driver also was tested on
OpenWrt build system where the option WERROR wasn't enabled as I was
devloping other stuff so this added on top of it of not noticing stuff.

I promise this won't ever happen again. Also I sent v2 for this hoping
things can get reverted and the correct series can be applied. If not I
can quickly send a followup that fix this. I verified with the repro
that the warning/error gets solved. (it's just channging the int to u8)

-- 
	Ansuel

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Fri, 12 Jul 2024, Christian Marangi wrote:

> On Fri, Jul 12, 2024 at 08:31:39AM +0100, Lee Jones wrote:
> > Christian,
> > 
> > > Hi all,
> > > 
> > > After merging the leds-lj tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > In file included from drivers/leds/leds-lp5569.c:11:
> > > drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
> > > drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
> > >   204 |                           chip, LP5569_REG_STATUS, &val);
> > >       |                                                    ^~~~
> > >       |                                                    |
> > >       |                                                    int *
> > 
> > The only reason for applying this set this late in the cycle was that
> > they appeared to be fixes for other brokenness.
> > 
> > This is the second set that you've submitted in recent days that has
> > caused build breakages.  Something is wrong with your current
> > development practices.  Are you able to identify and rectify these
> > issue(s) before a lose trust in your submissions?
> >
> 
> Yes, I identified the problem and the config was silently getting
> disabled and hiding all the errors/warning. Driver also was tested on
> OpenWrt build system where the option WERROR wasn't enabled as I was
> devloping other stuff so this added on top of it of not noticing stuff.
> 
> I promise this won't ever happen again. Also I sent v2 for this hoping
> things can get reverted and the correct series can be applied. If not I
> can quickly send a followup that fix this. I verified with the repro
> that the warning/error gets solved. (it's just channging the int to u8)

No need to follow up.

I've applied the new set and sent for pre-testing.

Once passed, I'll push so it'll end up in -next again.

-- 
Lee Jones [李琼斯]

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-pca955x.c: In function 'pca955x_probe':
drivers/leds/leds-pca955x.c:640:15: error: implicit declaration of function 'pca955x_num_led_regs'; did you mean 'pca955x_num_input_regs'? [-Wimplicit-function-declaration]
  640 |         nls = pca955x_num_led_regs(chip->bits);
      |               ^~~~~~~~~~~~~~~~~~~~
      |               pca955x_num_input_regs

Caused by commit

  14ef0738a31d ("leds: pca955x: Optimize probe LED selection")

I have used the led-lj tree from next-20250220 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/Kconfig:1027: can't open file "drivers/leds/simple/Kconfig"

Caused by commit

  f33c17919d44 ("leds: Rename simple directory to simatic")

I have used the leds-lj tree from next-20250320 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Fri, 21 Mar 2025, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/Kconfig:1027: can't open file "drivers/leds/simple/Kconfig"
> 
> Caused by commit
> 
>   f33c17919d44 ("leds: Rename simple directory to simatic")
> 
> I have used the leds-lj tree from next-20250320 for today.

Thanks.  This has been fixed in:

https://web.git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/?h=for-leds-next&id=835a0c10d33b54607f49edffbbeaea4c4cdcc49c

-- 
Lee Jones [李琼斯]

linux-next: build failure after merge of the leds-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

Caused by commit

  51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")

I have used the led-lj tree from next-20160108 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Fri, 09 Jan 2026, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
> ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> 
> Caused by commit
> 
>   51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")
> 
> I have used the led-lj tree from next-20160108 for today.

Steffen,

Please provide a follow-up patch post-haste.

-- 
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the leds-lj tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On Fri, Jan 09, 2026 at 09:41:47AM +0000, Lee Jones wrote:
> On Fri, 09 Jan 2026, Stephen Rothwell wrote:

> > ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
> > ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> > ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

> > Caused by commit

> >   51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")

> > I have used the led-lj tree from next-20160108 for today.

> Please provide a follow-up patch post-haste.

This issue is still present in today's -next.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Mon, 19 Jan 2026, Mark Brown wrote:

> On Fri, Jan 09, 2026 at 09:41:47AM +0000, Lee Jones wrote:
> > On Fri, 09 Jan 2026, Stephen Rothwell wrote:
> 
> > > ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
> > > ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> > > ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> 
> > > Caused by commit
> 
> > >   51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")
> 
> > > I have used the led-lj tree from next-20160108 for today.
> 
> > Please provide a follow-up patch post-haste.
> 
> This issue is still present in today's -next.

Steffen,

Please provide a follow-up or I'll have to remove your patch.

This is blocking testing.

-- 
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the leds-lj tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Fri, Jan 09, 2026 at 12:45:58PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
> ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

This issue is still present in today's -next.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

On Fri, Jan 09, 2026 at 12:45:58PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

This issue is still present in today's -next, the leds-lj tree is still
using the version from 8th January.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]

On Mon, Feb 02, 2026 at 02:56:27PM +0000, Mark Brown wrote:
> On Fri, Jan 09, 2026 at 12:45:58PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the leds-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> 
> This issue is still present in today's -next, the leds-lj tree is still
> using the version from 8th January.

This means that these commits have never been in -next and we're at -rc8
now:

Daniel Mack (3):
      dt-bindings: leds: Add issi,is31fl3293 to leds-is31fl32xx
      leds: is31f132xx: Re-order code to remove forward declarations
      leds: is31f132xx: Add support for is31fl3293

Nam Tran (3):
      dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver
      leds: Add basic support for TI/National Semiconductor LP5812 LED Driver
      docs: leds: Document TI LP5812 LED driver

Steffen Trumtrar (3):
      dt-bindings: leds: Add LP5860 LED controller
      leds: Add support for TI LP5860 LED driver chip
      leds: lp5860: Fix unused-but-set-variable warning

Jishnu Prakash (2):
      dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
      dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible

Lukas Timmermann (2):
      dt-bindings: leds: Add new as3668 support
      leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

Duje Mihanović (1):
      leds: expresswire: Fix chip state breakage

Haotian Zhang (1):
      leds: qcom-lpg: Check the return value of regmap_bulk_write()

J. Neuschäfer (1):
      dt-bindings: leds: Allow differently named multicolor LEDs

Krzysztof Kozlowski (1):
      leds: lp55xx: Simplify with scoped for each OF child loop

Vivek BalachandharTN (1):
      leds: lm3692x: Fix kernel-doc for struct lm3692x_led

The leds-lj tree in -next currently contains only:

Lukas Timmermann (2):
      dt-bindings: leds: Add new as3668 support
      leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds-lj tree

[Lee Jones]

On Tue, 03 Feb 2026, Mark Brown wrote:

> On Mon, Feb 02, 2026 at 02:56:27PM +0000, Mark Brown wrote:
> > On Fri, Jan 09, 2026 at 12:45:58PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the leds-lj tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > 
> > This issue is still present in today's -next, the leds-lj tree is still
> > using the version from 8th January.
> 
> This means that these commits have never been in -next and we're at -rc8
> now:
> 
> Daniel Mack (3):
>       dt-bindings: leds: Add issi,is31fl3293 to leds-is31fl32xx
>       leds: is31f132xx: Re-order code to remove forward declarations
>       leds: is31f132xx: Add support for is31fl3293
> 
> Nam Tran (3):
>       dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver
>       leds: Add basic support for TI/National Semiconductor LP5812 LED Driver
>       docs: leds: Document TI LP5812 LED driver
> 
> Steffen Trumtrar (3):
>       dt-bindings: leds: Add LP5860 LED controller
>       leds: Add support for TI LP5860 LED driver chip
>       leds: lp5860: Fix unused-but-set-variable warning
> 
> Jishnu Prakash (2):
>       dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
>       dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible
> 
> Lukas Timmermann (2):
>       dt-bindings: leds: Add new as3668 support
>       leds: as3668: Driver for the ams Osram 4-channel i2c LED driver
> 
> Duje Mihanović (1):
>       leds: expresswire: Fix chip state breakage
> 
> Haotian Zhang (1):
>       leds: qcom-lpg: Check the return value of regmap_bulk_write()
> 
> J. Neuschäfer (1):
>       dt-bindings: leds: Allow differently named multicolor LEDs
> 
> Krzysztof Kozlowski (1):
>       leds: lp55xx: Simplify with scoped for each OF child loop
> 
> Vivek BalachandharTN (1):
>       leds: lm3692x: Fix kernel-doc for struct lm3692x_led
> 
> The leds-lj tree in -next currently contains only:
> 
> Lukas Timmermann (2):
>       dt-bindings: leds: Add new as3668 support
>       leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

Apologies, I was on vacation all last week.

I have removed the offending commit.

-- 
Lee Jones [李琼斯]

linux-next: build failure after merge of the leds-lj tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 2181 bytes --]

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

/tmp/next/build/drivers/leds/led-class-multicolor.c: In function 'multi_intensity_store':
/tmp/next/build/include/linux/compiler_types.h:706:45: error: call to '__compiletime_assert_434' declared with attribute error: min(intensity_value[i], led_cdev->max_brightness) signedness error
  706 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
/tmp/next/build/include/linux/compiler_types.h:687:25: note: in definition of macro '__compiletime_assert'
  687 |                         prefix ## suffix();                             \
      |                         ^~~~~~
/tmp/next/build/include/linux/compiler_types.h:706:9: note: in expansion of macro '_compiletime_assert'
  706 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/build_bug.h:40:37: note: in expansion of macro 'compiletime_assert'
   40 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   93 |         BUILD_BUG_ON_MSG(!__types_ok(ux, uy),           \
      |         ^~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
   98 |         __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
      |         ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
  105 | #define min(x, y)       __careful_cmp(min, x, y)
      |                         ^~~~~~~~~~~~~
/tmp/next/build/drivers/leds/led-class-multicolor.c:51:38: note: in expansion of macro 'min'
   51 |                 intensity_value[i] = min(intensity_value[i],
      |                                      ^~~

Caused by commit

  787130d7bc49e (leds: multicolor: Limit intensity to max_brightness of LED)

I have used the version from next-20260305 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]