From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc()
Date: Wed, 22 Mar 2023 15:55:08 +0100 [thread overview]
Message-ID: <20230322155508.6f4acb80@xps-13> (raw)
In-Reply-To: <20230317074041.115036-1-jiapeng.chong@linux.alibaba.com>
Hi,
jiapeng.chong@linux.alibaba.com wrote on Fri, 17 Mar 2023 15:40:41
+0800:
> The function is_imx51_nfc is defined in the mxc_nand.c file, but not
> called elsewhere, so remove this unused function.
>
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx51_nfc'.
Thanks for your patch, but apparently is_imx53_nfc() is also unused,
strange the robot did not pick this up. Anyway, no need to resend, I
received another patch removing both functions already.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4559
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/mtd/nand/raw/mxc_nand.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
> index f6c96341b896..16d795c25609 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
> return host->devtype_data == &imx25_nand_devtype_data;
> }
>
> -static inline int is_imx51_nfc(struct mxc_nand_host *host)
> -{
> - return host->devtype_data == &imx51_nand_devtype_data;
> -}
> -
> static inline int is_imx53_nfc(struct mxc_nand_host *host)
> {
> return host->devtype_data == &imx53_nand_devtype_data;
Thanks,
Miquèl
prev parent reply other threads:[~2023-03-22 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 7:40 [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc() Jiapeng Chong
2023-03-22 14:55 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322155508.6f4acb80@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox