* [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()
@ 2023-03-22 8:22 ye.xingchen
2023-03-22 9:06 ` Laurent Pinchart
2023-03-22 10:53 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2023-03-22 8:22 UTC (permalink / raw)
To: laurent.pinchart
Cc: andrzej.hajda, neil.armstrong, rfoss, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Replace the open-code with dev_err_probe() to simplify the code.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/gpu/drm/bridge/simple-bridge.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index 5ede3e111096..d85d9ee463b8 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -202,11 +202,9 @@ static int simple_bridge_probe(struct platform_device *pdev)
sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable",
GPIOD_OUT_LOW);
- if (IS_ERR(sbridge->enable)) {
- if (PTR_ERR(sbridge->enable) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Unable to retrieve enable GPIO\n");
- return PTR_ERR(sbridge->enable);
- }
+ if (IS_ERR(sbridge->enable))
+ return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable),
+ "Unable to retrieve enable GPIO\n");
/* Register the bridge. */
sbridge->bridge.funcs = &simple_bridge_bridge_funcs;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()
2023-03-22 8:22 [PATCH] drm: bridge: simple-bridge: Use dev_err_probe() ye.xingchen
@ 2023-03-22 9:06 ` Laurent Pinchart
2023-03-22 10:53 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2023-03-22 9:06 UTC (permalink / raw)
To: ye.xingchen
Cc: andrzej.hajda, neil.armstrong, rfoss, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel
Hi Ye,
Thank you for the patch.
On Wed, Mar 22, 2023 at 04:22:51PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/simple-bridge.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 5ede3e111096..d85d9ee463b8 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -202,11 +202,9 @@ static int simple_bridge_probe(struct platform_device *pdev)
>
> sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable",
> GPIOD_OUT_LOW);
> - if (IS_ERR(sbridge->enable)) {
> - if (PTR_ERR(sbridge->enable) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Unable to retrieve enable GPIO\n");
> - return PTR_ERR(sbridge->enable);
> - }
> + if (IS_ERR(sbridge->enable))
> + return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable),
> + "Unable to retrieve enable GPIO\n");
>
> /* Register the bridge. */
> sbridge->bridge.funcs = &simple_bridge_bridge_funcs;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()
2023-03-22 8:22 [PATCH] drm: bridge: simple-bridge: Use dev_err_probe() ye.xingchen
2023-03-22 9:06 ` Laurent Pinchart
@ 2023-03-22 10:53 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-03-22 10:53 UTC (permalink / raw)
To: laurent.pinchart, ye.xingchen
Cc: andrzej.hajda, rfoss, jonas, jernej.skrabec, airlied, daniel,
dri-devel, linux-kernel
Hi,
On Wed, 22 Mar 2023 16:22:51 +0800, ye.xingchen@zte.com.cn wrote:
> Replace the open-code with dev_err_probe() to simplify the code.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm: bridge: simple-bridge: Use dev_err_probe()
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=db8496d0b50519540e1ee50f7e209b3a536ed671
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-22 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-22 8:22 [PATCH] drm: bridge: simple-bridge: Use dev_err_probe() ye.xingchen
2023-03-22 9:06 ` Laurent Pinchart
2023-03-22 10:53 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox