Re: [PATCH -next v6 2/2] mm/zswap: delay the initializaton of zswap

Vitaly Wool
2023-03-27T06:20:13Z

On Thu, Mar 23, 2023 at 8:59 AM Christoph Hellwig <hch@lst.de> wrote:
>
> On Wed, Mar 22, 2023 at 06:17:12PM +0100, Vitaly Wool wrote:
> > On Wed, Mar 22, 2023 at 10:30 AM Liu Shixin <liushixin2@huawei.com> wrote:
> > >
> > > Since some users may not use zswap, the zswap_pool is wasted. Save memory
> > > by delaying the initialization of zswap until enabled.
> >
> > To be honest, I'm not a huge fan of this. Would enabling zswap module
> > build instead solve your problem?
>
> making zswap build modular would be a mess. It is core MM infrastructure
> and now we'd need to start dealing with adding and removing it at
> runtime as well as module refcounting.

Since when is it a core MM infrastructure? It is basically just a
frontswap frontend.

~Vitaly