Re: [PATCH v3 2/6] mfd: Add support for the Lantiq PEF2256 framer

Herve Codina
2023-03-23T08:32:06Z

On Thu, 23 Mar 2023 08:30:39 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 22/03/2023 14:46, Herve Codina wrote:
> > The Lantiq PEF2256 is a framer and line interface component designed to
> > fulfill all required interfacing between an analog E1/T1/J1 line and the
> > digital PCM system highway/H.100 bus.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>
>
> > +static const struct of_device_id pef2256_id_table[] = {
> > + { .compatible = "lantiq,pef2256" },
> > + {} /* sentinel */
> > +};
> > +MODULE_DEVICE_TABLE(of, pef2256_id_table);
> > +
> > +static struct platform_driver pef2256_driver = {
> > + .driver = {
> > + .name = "lantiq-pef2256",
> > + .of_match_table = of_match_ptr(pef2256_id_table),
>
> Drop of_match_ptr. This will case warnings with W=1 and !OF.
>
> Best regards,
> Krzysztof
>

Acked. Will be dropped in v4.

Thanks.
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering