RE: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master

Ping-Ke Shih
2023-03-27T00:38:12Z

> -----Original Message-----
> From: Cai Huoqing <cai.huoqing@linux.dev>
> Sent: Thursday, March 23, 2023 7:26 PM
> To: cai.huoqing@linux.dev
> Cc: Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Yan-Hsuan Chuang
> <tony0620emma@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>; ath10k@lists.infradead.org;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> ath11k@lists.infradead.org; ath12k@lists.infradead.org
> Subject: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master
>
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index b4bd831c9845..60145d2f3e5a 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1552,7 +1552,6 @@ static int rtw_pci_claim(struct rtw_dev *rtwdev, struct pci_dev *pdev)
>
> static void rtw_pci_declaim(struct rtw_dev *rtwdev, struct pci_dev *pdev)
> {
> - pci_clear_master(pdev);
> pci_disable_device(pdev);
> }
>
> --
> 2.34.1