From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86531C6FD1D for ; Thu, 23 Mar 2023 13:46:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbjCWNqh (ORCPT ); Thu, 23 Mar 2023 09:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230335AbjCWNqd (ORCPT ); Thu, 23 Mar 2023 09:46:33 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ECF829E31; Thu, 23 Mar 2023 06:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679579192; x=1711115192; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9ennairkf3iy0DLpGRVHy/xvU8CQYM6AxEOs9CSrRLY=; b=n84k5Mr+WnnIXTGJdpSsQtWXgh52fA39Kj/VLzG2jDFgyWZ9eZdBshjZ Pzg/r2f7UPFWN8XkO1ZVzr58nhJC5QaYjsyyTAbMYddS5app9dhOug5st wxvCA047HpGp6vN2ijZji3Jv2+6OCsH/TyqpuwDxUconRvpVa5/ZEglYl E6MCbFoxCG+s+rSKPtyzv2MNRwZglHMJScPP3DGcfBFBGvq0UMmeG2tLT +LnkGa1wN/zSodgWjvTozlZgcYcSfrLf9xuQYESCM/Z8iMxQQiTsDd1jn nDahcQobPOlXb+eFdHBAzKlJqbddLV+C0mqUYaGbyj4s3Nx+LHv/OEc2q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="339523432" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="339523432" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 06:46:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="928241273" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="928241273" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga006.fm.intel.com with ESMTP; 23 Mar 2023 06:46:28 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pfLGt-000EPt-2m; Thu, 23 Mar 2023 13:46:27 +0000 Date: Thu, 23 Mar 2023 21:46:10 +0800 From: kernel test robot To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, bvanassche@acm.org, John Garry Subject: Re: [PATCH v2 06/11] scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd Message-ID: <202303232141.ElpLC72H-lkp@intel.com> References: <20230323094555.584624-7-john.g.garry@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323094555.584624-7-john.g.garry@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on next-20230323] [cannot apply to jejb-scsi/for-next linus/master v6.3-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/John-Garry/scsi-scsi_debug-Fix-check-for-sdev-queue-full/20230323-175305 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20230323094555.584624-7-john.g.garry%40oracle.com patch subject: [PATCH v2 06/11] scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20230323/202303232141.ElpLC72H-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/be81e49de2c71f280dd3eac902d05afcb1061d12 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review John-Garry/scsi-scsi_debug-Fix-check-for-sdev-queue-full/20230323-175305 git checkout be81e49de2c71f280dd3eac902d05afcb1061d12 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/scsi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303232141.ElpLC72H-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/scsi/scsi_debug.c:5579:27: warning: no previous prototype for function 'sdebug_alloc_queued_cmd' [-Wmissing-prototypes] struct sdebug_queued_cmd *sdebug_alloc_queued_cmd(struct scsi_cmnd *scmd) ^ drivers/scsi/scsi_debug.c:5579:1: note: declare 'static' if the function is not intended to be used outside of this translation unit struct sdebug_queued_cmd *sdebug_alloc_queued_cmd(struct scsi_cmnd *scmd) ^ static 1 warning generated. vim +/sdebug_alloc_queued_cmd +5579 drivers/scsi/scsi_debug.c 5578 > 5579 struct sdebug_queued_cmd *sdebug_alloc_queued_cmd(struct scsi_cmnd *scmd) 5580 { 5581 struct sdebug_queued_cmd *sqcp = kmem_cache_zalloc(queued_cmd_cache, GFP_ATOMIC); 5582 struct sdebug_defer *sd_dp; 5583 5584 if (!sqcp) 5585 return NULL; 5586 5587 sd_dp = &sqcp->sd_dp; 5588 5589 hrtimer_init(&sd_dp->hrt, CLOCK_MONOTONIC, HRTIMER_MODE_REL_PINNED); 5590 sd_dp->hrt.function = sdebug_q_cmd_hrt_complete; 5591 INIT_WORK(&sd_dp->ew.work, sdebug_q_cmd_wq_complete); 5592 5593 sqcp->scmd = scmd; 5594 sd_dp->sqa_idx = -1; 5595 5596 return sqcp; 5597 } 5598 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests