From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: ye.xingchen@zte.com.cn
Cc: andersson@kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc/davinci: Use dev_err_probe()
Date: Thu, 23 Mar 2023 16:36:43 -0600 [thread overview]
Message-ID: <20230323223643.GA2905636@p14s> (raw)
In-Reply-To: <202303231600496082749@zte.com.cn>
On Thu, Mar 23, 2023 at 04:00:49PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index 98e0be9476a4..b2b7d3347949 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -278,13 +278,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> }
>
> dsp_reset = devm_reset_control_get_exclusive(dev, NULL);
> - if (IS_ERR(dsp_reset)) {
> - if (PTR_ERR(dsp_reset) != -EPROBE_DEFER)
> - dev_err(dev, "unable to get reset control: %ld\n",
> - PTR_ERR(dsp_reset));
> -
> - return PTR_ERR(dsp_reset);
> - }
> + if (IS_ERR(dsp_reset))
> + return dev_err_probe(dev, PTR_ERR(dsp_reset),
> + "unable to get reset control: %ld\n");
This patch is obviously wrong and doesn't even compile.
>
> if (dev->of_node) {
> ret = of_reserved_mem_device_init(dev);
> --
> 2.25.1
next prev parent reply other threads:[~2023-03-23 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 8:00 [PATCH] remoteproc/davinci: Use dev_err_probe() ye.xingchen
2023-03-23 22:36 ` Mathieu Poirier [this message]
2023-03-25 19:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323223643.GA2905636@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox