public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chester Lin <clin@suse.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, "Chester Lin" <clin@suse.com>,
	"NXP S32 Linux Team" <s32@nxp.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Ghennadi Procopciuc" <Ghennadi.Procopciuc@oss.nxp.com>,
	"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
	"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>
Subject: Re: [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to get device data
Date: Fri, 24 Mar 2023 01:11:37 +0800	[thread overview]
Message-ID: <202303240158.uaLsPb4O-lkp@intel.com> (raw)
In-Reply-To: <20230323144833.28562-2-clin@suse.com>

Hi Chester,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next next-20230323]
[cannot apply to linus/master v6.3-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chester-Lin/pinctrl-s32g2-use-of_device_get_match_data-to-get-device-data/20230323-225141
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link:    https://lore.kernel.org/r/20230323144833.28562-2-clin%40suse.com
patch subject: [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to get device data
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230324/202303240158.uaLsPb4O-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b716f96ba217e92e79b0d888f187ba0f30d705cf
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Chester-Lin/pinctrl-s32g2-use-of_device_get_match_data-to-get-device-data/20230323-225141
        git checkout b716f96ba217e92e79b0d888f187ba0f30d705cf
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/nxp/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303240158.uaLsPb4O-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/pinctrl/nxp/pinctrl-s32g2.c: In function 's32g_pinctrl_probe':
>> drivers/pinctrl/nxp/pinctrl-s32g2.c:747:40: warning: passing argument 2 of 's32_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     747 |         return s32_pinctrl_probe(pdev, info);
         |                                        ^~~~
   In file included from drivers/pinctrl/nxp/pinctrl-s32g2.c:18:
   drivers/pinctrl/nxp/pinctrl-s32.h:70:54: note: expected 'struct s32_pinctrl_soc_info *' but argument is of type 'const struct s32_pinctrl_soc_info *'
      70 |                         struct s32_pinctrl_soc_info *info);
         |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~


vim +747 drivers/pinctrl/nxp/pinctrl-s32g2.c

   740	
   741	static int s32g_pinctrl_probe(struct platform_device *pdev)
   742	{
   743		const struct s32_pinctrl_soc_info *info;
   744	
   745		info = of_device_get_match_data(&pdev->dev);
   746	
 > 747		return s32_pinctrl_probe(pdev, info);
   748	}
   749	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

  reply	other threads:[~2023-03-23 17:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 14:48 [PATCH v3 0/6] pinctrl: s32: driver improvements and generic struct use Chester Lin
2023-03-23 14:48 ` [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to get device data Chester Lin
2023-03-23 17:11   ` kernel test robot [this message]
2023-03-23 17:42     ` Chester Lin
2023-03-23 14:48 ` [PATCH v3 2/6] pinctrl: s32: refine error/return/config checks and simplify driver codes Chester Lin
2023-03-23 14:48 ` [PATCH v3 3/6] pinctrl: s32cc: refactor pin config parsing Chester Lin
2023-03-23 18:44   ` Andy Shevchenko
2023-03-23 14:48 ` [PATCH v3 4/6] pinctrl: s32cc: embed generic struct pingroup Chester Lin
2023-03-23 14:48 ` [PATCH v3 5/6] pinctrl: s32cc: Use generic struct data to describe pin function Chester Lin
2023-03-23 18:49   ` Andy Shevchenko
2023-03-23 14:48 ` [PATCH v3 6/6] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info Chester Lin
2023-03-23 18:50   ` Andy Shevchenko
2023-03-24  7:45     ` Chester Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303240158.uaLsPb4O-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Ghennadi.Procopciuc@oss.nxp.com \
    --cc=afaerber@suse.de \
    --cc=andrei.stefanescu@nxp.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=clin@suse.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbrugger@suse.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=radu-nicolae.pirea@nxp.com \
    --cc=s32@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox