Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI watchdog driver

Rob Herring
2023-03-24T20:34:42Z

On Fri, Mar 24, 2023 at 08:26:51PM +0530, Bharat Bhushan wrote:
> Add binding documentation for the Marvell octeonTX2
> GTI watchdog driver.
>
> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> ---
> .../watchdog/marvel-octeontx2-wdt.yaml | 43 +++++++++++++++++++

The comics?

Use compatible string for filename.

> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml
> new file mode 100644
> index 000000000000..586b3c1bd780
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/marvel-octeontx2-wdt.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/marvel-octeontx2-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell OcteonTX2 GTI watchdog
> +
> +allOf:
> + - $ref: "watchdog.yaml#"

Drop quotes

> +
> +maintainers:
> + - Bharat Bhushan <bbhushan2@marvell.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mrvl,octeontx2-gti-wdt

'mrvl' is deprecated. Use 'marvell'

> +
> + reg:
> + maxItems: 2

Need to define what each entry is.

> +
> + interrupts:
> + minItems: 1
> + maxItems: 36

Need to define what each entry is. How does the h/w have a variable
number of interrupts?

> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + watch-dog@802000040000 {

watchdog@...

> + compatible = "mrvl,octeontx2-gti-wdt";
> + reg = <0x8020 0x40000 0x0 0x20000>;
> + interrupts = <0 38 1>, /* Core-0 */
> + <0 39 1>; /* Core-1 */
> + };
> +
> +...
> --
> 2.17.1
>