From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: vkoul@kernel.org, kishon@kernel.org, michal.simek@xilinx.com,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, git@amd.com
Subject: Re: [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol
Date: Fri, 24 Mar 2023 22:44:02 +0200 [thread overview]
Message-ID: <20230324204402.GD23868@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1679660679-10409-1-git-send-email-radhey.shyam.pandey@amd.com>
Hi Radhey,
Thank you for the patch.
On Fri, Mar 24, 2023 at 05:54:39PM +0530, Radhey Shyam Pandey wrote:
> SGMII is validated on kria KR260 robotics starter kit. So modify the
> comment description to include it in supported controllers list.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> drivers/phy/xilinx/phy-zynqmp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
> index 9be9535ad7ab..ebe5ba730234 100644
> --- a/drivers/phy/xilinx/phy-zynqmp.c
> +++ b/drivers/phy/xilinx/phy-zynqmp.c
> @@ -8,9 +8,9 @@
> * Author: Subbaraya Sundeep <sundeep.lkml@gmail.com>
> * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> *
> - * This driver is tested for USB, SATA and Display Port currently.
> - * Other controllers PCIe and SGMII should also work but that is
> - * experimental as of now.
> + * This driver is tested for USB, SGMII, SATA and Display Port currently.
> + * Other controller i.e PCIe should also work but that is experimental
As only PCIe is left, I'd write
* PCIe should also work but that is experimental as of now.
With that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Of course it would be even better if you could test PCIe ;-)
> + * as of now.
> */
>
> #include <linux/clk.h>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2023-03-24 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 12:24 [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol Radhey Shyam Pandey
2023-03-24 20:44 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324204402.GD23868@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=git@amd.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox