From: "Theodore Ts'o" <tytso@mit.edu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Change in kernel debian packages between -rc2 and -rc3
Date: Sat, 25 Mar 2023 10:31:22 -0400 [thread overview]
Message-ID: <20230325143122.GA409315@mit.edu> (raw)
Hi Masahiro,
It appears that there is a backwards-incompatible (and, I believe,
incorrect) change in the package version used when generated Debian
packages between 6.2-rc2 and 6.2-rc3.
I have CONFIG_LOCALVERSION set in my .config:
CONFIG_LOCALVERSION="-xfstests"
As a result, the uname -a of a kernel that I build contains -xfstests,
e.g:
root@kvm-xfstests:~# uname -r
6.3.0-rc3-xfstests-00043-g463f2e46bf7c
Previously this would be correctly reflected in the Debian package
version:
% dpkg -I /build/linux-image-6.3.0-rc2-xfstests_6.3.0-rc2-xfstests-1016_amd64.deb
...
Package: linux-image-6.3.0-rc2-xfstests
Source: linux-6.3.0-rc2-xfstests
Version: 6.3.0-rc2-xfstests-1016
...
However, after -rc3, the CONFIG_LOCALVERSION is no longer present in the package version:
% dpkg -I /build/linux-image-6.3.0-rc3-xfstests-00043-g463f2e46bf7c_6.3.0-rc3-00043-g463f2e46bf7c-1017_amd64.deb
...
Package: linux-image-6.3.0-rc3-xfstests-00043-g463f2e46bf7c
Source: linux-6.3.0-rc3-xfstests-00043-g463f2e46bf7c
Version: 6.3.0-rc3-00043-g463f2e46bf7c-1017
...
Note the missing "-xfstests" in the above Version. This also shows up
in the name of the .deb file which is generated, and this is breaking
my kernel build script[1].
[1] https://github.com/tytso/xfstests-bld/blob/master/kernel-build/kbuild
I assume the problem is caused by one of these two commits:
36862e14e316 ("kbuild: deb-pkg: use dh_listpackages to know enabled packages")
b611daae5efc ("kbuild: deb-pkg: split image and debug objects staging out into functions")
As these are the two commits which touch the builddeb script.
Could you please take a look?
Many thanks,
- Ted
next reply other threads:[~2023-03-25 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 14:31 Theodore Ts'o [this message]
2023-03-26 3:39 ` Change in kernel debian packages between -rc2 and -rc3 Masahiro Yamada
2023-03-26 12:11 ` Theodore Ts'o
2023-03-27 7:34 ` Kalle Valo
2023-03-27 13:35 ` Masahiro Yamada
2023-03-28 4:09 ` Theodore Ts'o
2023-04-02 3:37 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325143122.GA409315@mit.edu \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox