Re: [PATCH -next v7 2/4] mm/zswap: skip invalid or unchanged parameter

Sergey Senozhatsky
2023-03-26T04:53:37Z

On (23/03/26 12:17), Sergey Senozhatsky wrote:
> On (23/03/25 15:14), Liu Shixin wrote:
> > static int zswap_enabled_param_set(const char *val,
> > const struct kernel_param *kp)
> > {
> > + bool res;
> > +
> > + if (kstrtobool(val, &res))
> > + return -EINVAL;
> > +
> > + /* no change required */
> > + if (res == *(bool *)kp->arg)
> > + return 0;
>
> Bool kernel param can be any of these letters 'YyTt1NnFf0'. Doing things
> to kp->arg outside of kernel/params.c is not going to be easy, let's not
> even try.

Please disregard my previous email. kp->arg is always true or false
at this point. I'd still prefer to not do kp->arg in zswap.