* [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields
@ 2023-03-13 0:49 Peng Fan (OSS)
2023-03-27 1:53 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan (OSS) @ 2023-03-13 0:49 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, linux-kernel, linux-arm-kernel,
Peng Fan, kernel test robot
From: Peng Fan <peng.fan@nxp.com>
The clang-analyzer reports:
"Excessive padding in 'struct imx8m_blk_ctrl_domain_data'
(12 padding bytes, where 4 is optimal). Optimal fields order: name,
clk_names, path_names, gpc_name, num_clks, num_paths, rst_mask, clk_mask,
mipi_phy_rst_mask, consider reordering the fields or adding explicit
padding members [clang-analyzer-optin.performance.Padding]
struct imx8m_blk_ctrl_domain_data {"
So reordering the fields.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/soc/imx/imx8m-blk-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index 9b0f81dc292b..716e6eb4838f 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -37,10 +37,10 @@ struct imx8m_blk_ctrl {
struct imx8m_blk_ctrl_domain_data {
const char *name;
const char * const *clk_names;
- int num_clks;
const char * const *path_names;
- int num_paths;
const char *gpc_name;
+ int num_clks;
+ int num_paths;
u32 rst_mask;
u32 clk_mask;
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields
2023-03-13 0:49 [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields Peng Fan (OSS)
@ 2023-03-27 1:53 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2023-03-27 1:53 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: s.hauer, kernel, festevam, linux-imx, linux-kernel,
linux-arm-kernel, Peng Fan, kernel test robot
On Mon, Mar 13, 2023 at 08:49:03AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The clang-analyzer reports:
> "Excessive padding in 'struct imx8m_blk_ctrl_domain_data'
> (12 padding bytes, where 4 is optimal). Optimal fields order: name,
> clk_names, path_names, gpc_name, num_clks, num_paths, rst_mask, clk_mask,
> mipi_phy_rst_mask, consider reordering the fields or adding explicit
> padding members [clang-analyzer-optin.performance.Padding]
> struct imx8m_blk_ctrl_domain_data {"
>
> So reordering the fields.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-27 1:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-13 0:49 [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields Peng Fan (OSS)
2023-03-27 1:53 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox