* [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
@ 2023-03-27 7:36 Cai Huoqing
2023-03-27 15:48 ` Logan Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2023-03-27 7:36 UTC (permalink / raw)
To: cai.huoqing; +Cc: Bjorn Helgaas, Logan Gunthorpe, linux-pci, linux-kernel
Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
because pci_p2pmem_dma() is already removed.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/pci/p2pdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 9e8205572830..4f1798ecf38f 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
/**
* pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
* the specified list of clients and shortest distance (as determined
- * by pci_p2pmem_dma())
+ * by pci_p2pdma_map_segment())
* @clients: array of devices to check (NULL-terminated)
* @num_clients: number of client devices in the list
*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
2023-03-27 7:36 [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many() Cai Huoqing
@ 2023-03-27 15:48 ` Logan Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Logan Gunthorpe @ 2023-03-27 15:48 UTC (permalink / raw)
To: Cai Huoqing; +Cc: Bjorn Helgaas, linux-pci, linux-kernel
On 2023-03-27 01:36, Cai Huoqing wrote:
> Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
> because pci_p2pmem_dma() is already removed.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Thanks for noticing this!
> ---
> drivers/pci/p2pdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..4f1798ecf38f 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
> /**
> * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
> * the specified list of clients and shortest distance (as determined
> - * by pci_p2pmem_dma())
> + * by pci_p2pdma_map_segment())
Maybe we should just remove the reference to pci_p2pdma_map_segment()
completely. I don't see how that function helps the reader any more and
is really different section of the API anyway.
Logan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-27 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-27 7:36 [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many() Cai Huoqing
2023-03-27 15:48 ` Logan Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox