From: Jakub Kicinski <kuba@kernel.org>
To: Min Li <min.li.xe@renesas.com>
Cc: Min Li <lnimi@hotmail.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"lee@kernel.org" <lee@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH mfd-n 1/2] ptp: clockmatrix: support 32-bit address space
Date: Mon, 27 Mar 2023 10:37:11 -0700 [thread overview]
Message-ID: <20230327103711.7d73ea09@kernel.org> (raw)
In-Reply-To: <OS3PR01MB6593510463322D4410EB8D59BA8B9@OS3PR01MB6593.jpnprd01.prod.outlook.com>
On Mon, 27 Mar 2023 14:54:41 +0000 Min Li wrote:
> > On Thu, 23 Mar 2023 12:15:17 -0400 Min Li wrote:
> > > - err = idtcm_write(idtcm, 0, HW_Q8_CTRL_SPARE,
> > > + err = idtcm_write(idtcm, HW_Q8_CTRL_SPARE, 0,
> > > &temp, sizeof(temp));
> >
> > The flipping of the arguments should also be a separate patch.
>
> Hi Jakub
>
> If I separate this change, the other patch would be broken since it changed
> HW_Q8_CTRL_SPARE from a u16 value to u32 and it doesn't fit the function's
> particular parameter anymore
Both arguments are u16 now, so nothing can overflow until you change
the addresses to be u32.
patch 1 - reorder the arguments
patch 2 - bump the types to u32
patch 3 - change the addresses
prev parent reply other threads:[~2023-03-27 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:15 [PATCH mfd-n 1/2] ptp: clockmatrix: support 32-bit address space Min Li
2023-03-23 16:56 ` Jakub Kicinski
2023-03-27 14:54 ` Min Li
2023-03-27 17:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327103711.7d73ea09@kernel.org \
--to=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnimi@hotmail.com \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox