Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

Krzysztof Kozlowski
2023-03-28T10:07:28Z

On 28/03/2023 11:53, Andi Shyti wrote:
> Hi,
>
> On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote:
>> On 28/03/2023 07:38, Yang Li wrote:
>>> According to commit 890cc39a8799 ("drivers: provide
>>> devm_platform_get_and_ioremap_resource()"), convert
>>
>> I don't understand why do you reference this commit. There is no bug
>> introduced there, there is nothing related to this driver.
>>
>>> platform_get_resource(), devm_ioremap_resource() to a single
>>> call to devm_platform_get_and_ioremap_resource(), as this is exactly
>>> what this function does.
>
> I've seen Yang has sent many of these cleanups, perhaps he can
> write something like:
>
> "
> Commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()") introduces the
> devm_platform_get_and_ioremap_resource() function which combines
> both platform_get_resource() and devm_ioremap_resource() into a
> single call.

I don't think we need to reference that commit at all. It does not
matter when the API was introduced and just makes commit msg unnecessary
long. Instead the commit msg should shortly say why this change is
needed or even worth accepting.

>
> Update the code to use the new combined function instead of the
> separate calls.

Best regards,
Krzysztof