Re: [PATCH v2 04/15] dmaengine: idxd: Export descriptor management functions

Dave Jiang
2023-03-28T16:06:26Z

On 3/28/23 8:35 AM, Tom Zanussi wrote:
> To allow idxd sub-drivers to access the descriptor management
> functions, export them.
>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
> drivers/dma/idxd/submit.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/idxd/submit.c b/drivers/dma/idxd/submit.c
> index c01db23e3333..9d9ec0b76ccd 100644
> --- a/drivers/dma/idxd/submit.c
> +++ b/drivers/dma/idxd/submit.c
> @@ -61,6 +61,7 @@ struct idxd_desc *idxd_alloc_desc(struct idxd_wq *wq, enum idxd_op_type optype)
>
> return __get_desc(wq, idx, cpu);
> }
> +EXPORT_SYMBOL_NS_GPL(idxd_alloc_desc, IDXD);
>
> void idxd_free_desc(struct idxd_wq *wq, struct idxd_desc *desc)
> {
> @@ -69,6 +70,7 @@ void idxd_free_desc(struct idxd_wq *wq, struct idxd_desc *desc)
> desc->cpu = -1;
> sbitmap_queue_clear(&wq->sbq, desc->id, cpu);
> }
> +EXPORT_SYMBOL_NS_GPL(idxd_free_desc, IDXD);
>
> static struct idxd_desc *list_abort_desc(struct idxd_wq *wq, struct idxd_irq_entry *ie,
> struct idxd_desc *desc)
> @@ -215,3 +217,4 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc)
> percpu_ref_put(&wq->wq_active);
> return 0;
> }
> +EXPORT_SYMBOL_GPL(idxd_submit_desc);

This one should use the EXPORT_SYMBOL_NS_GPL() as above?