From: Yajun Deng <yajun.deng@linux.dev>
To: rafael@kernel.org, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Yajun Deng <yajun.deng@linux.dev>
Subject: [PATCH] cpufreq: Fix policy->freq_table is NULL in __cpufreq_driver_target()
Date: Wed, 29 Mar 2023 21:36:00 +0800 [thread overview]
Message-ID: <20230329133600.908723-1-yajun.deng@linux.dev> (raw)
__resolve_freq() may be return target_freq if policy->freq_table is
NULL. In this case, it should return -EINVAL before __target_index().
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
drivers/cpufreq/cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index c0e5be0fe2d6..308a3df1a940 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2299,7 +2299,7 @@ int __cpufreq_driver_target(struct cpufreq_policy *policy,
return cpufreq_driver->target(policy, target_freq, relation);
}
- if (!cpufreq_driver->target_index)
+ if (!cpufreq_driver->target_index || !policy->freq_table)
return -EINVAL;
return __target_index(policy, policy->cached_resolved_idx);
--
2.25.1
next reply other threads:[~2023-03-29 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 13:36 Yajun Deng [this message]
2023-03-29 14:21 ` [PATCH] cpufreq: Fix policy->freq_table is NULL in __cpufreq_driver_target() Rafael J. Wysocki
2023-03-30 1:39 ` Yajun Deng
2023-03-30 3:57 ` Viresh Kumar
2023-03-30 10:10 ` Rafael J. Wysocki
2023-04-03 4:11 ` Viresh Kumar
2023-04-04 3:08 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329133600.908723-1-yajun.deng@linux.dev \
--to=yajun.deng@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox