Re: [RFC PATCH v2 40/48] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage

Chuck Lever III
2023-03-30T13:16:32Z

> On Mar 30, 2023, at 5:41 AM, David Howells <dhowells@redhat.com> wrote:
>
> Chuck Lever III <chuck.lever@oracle.com> wrote:
>
>>> + if (ret > 0)
>>> + *sentp = ret;
>
> Should that be:
>
> *sentp = ret - sizeof(marker);
>
> David
>

That's a bit out of context, but ...

The return value of ->xpo_sendto is effectively ignored. There is
no caller of svc_process that checks its return code.

svc_rdma_sendto(), for example, returns zero or a negative errno.

That should be cleaned up one day.

--
Chuck Lever