Re: [RFC PATCH v2 16/48] ip, udp: Support MSG_SPLICE_PAGES

David Howells
2023-03-30T14:40:59Z

Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:

> > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
>
> A non-RFC version would require the same for ipv6, of course.

I missed the fact that ipv6 had it's own version of __ip_append_data() despite
sharing tcp_sendmsg(). Could __ip_append_data() and __ip6_append_data() be
shared? I guess that the v6_cork, the flowi6 and the ipcm6_cookie might
prevent that.

David