Re: [RFC PATCH v2 16/48] ip, udp: Support MSG_SPLICE_PAGES

Willem de Bruijn
2023-03-30T17:46:59Z

David Howells wrote:
> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>
> > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> >
> > A non-RFC version would require the same for ipv6, of course.
>
> I missed the fact that ipv6 had it's own version of __ip_append_data() despite
> sharing tcp_sendmsg(). Could __ip_append_data() and __ip6_append_data() be
> shared? I guess that the v6_cork, the flowi6 and the ipcm6_cookie might
> prevent that.

We haven't been able to unify them before. As this series is
complex enough as is, I would not attempt to include it.

If it grows the code, maybe it'll be an incentive to take
another look afterwards.