public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the tpmdd tree
Date: Thu, 30 Mar 2023 01:05:08 +0300	[thread overview]
Message-ID: <20230329220508.qdbjvmveolujj326@kernel.org> (raw)
In-Reply-To: <20230324132050.050d4780@canb.auug.org.au>

On Fri, Mar 24, 2023 at 01:20:50PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 21 Mar 2023 11:54:13 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the tpmdd tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/char/tpm/tpm-chip.c: In function 'tpm_amd_is_rng_defective':
> > drivers/char/tpm/tpm-chip.c:531:15: error: too many arguments to function 'tpm_request_locality'
> >   531 |         ret = tpm_request_locality(chip, 0);
> >       |               ^~~~~~~~~~~~~~~~~~~~
> > drivers/char/tpm/tpm-chip.c:35:12: note: declared here
> >    35 | static int tpm_request_locality(struct tpm_chip *chip)
> >       |            ^~~~~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   923c8dfa9a36 ("tpm: fix build break in tpm-chip.c caused by AMD fTPM quirk")
> > 
> > I have used the tmpdd tree from next-20230320 for today.
> 
> I am still getting this build failure.
> 
> The commit above is trying to fix a build failure that does not exist
> in the tmpdd tree!
> 

Hi sorry for the latency, I got sick on Friday and was sick leave
up until Tuesday.

The offending commit has been removed.

BR, Jarkko

  reply	other threads:[~2023-03-29 22:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21  0:54 linux-next: build failure after merge of the tpmdd tree Stephen Rothwell
2023-03-24  2:20 ` Stephen Rothwell
2023-03-29 22:05   ` Jarkko Sakkinen [this message]
2023-03-29 22:03 ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2023-04-27 12:55 broonie
2023-04-27 19:06 ` Jarkko Sakkinen
2019-06-05  2:09 Stephen Rothwell
2019-06-05 14:52 ` Jarkko Sakkinen
2019-04-16  3:07 Stephen Rothwell
2019-04-16 15:36 ` Jarkko Sakkinen
2019-04-18 19:40   ` Matthew Garrett
2019-04-30 14:47     ` Jarkko Sakkinen
2017-05-10  3:23 Stephen Rothwell
2017-05-10 12:51 ` Jarkko Sakkinen
2016-04-28  5:32 Stephen Rothwell
2016-04-28  9:02 ` Jarkko Sakkinen
2016-05-01 13:12   ` Stephen Rothwell
2016-05-02 11:10     ` Jarkko Sakkinen
2016-05-02 12:19       ` Stephen Rothwell
2016-05-02 16:26         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230329220508.qdbjvmveolujj326@kernel.org \
    --to=jarkko@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox