From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE53EC761AF for ; Thu, 30 Mar 2023 11:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231663AbjC3LdN (ORCPT ); Thu, 30 Mar 2023 07:33:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbjC3LdL (ORCPT ); Thu, 30 Mar 2023 07:33:11 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D875D30D2; Thu, 30 Mar 2023 04:33:03 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1phqWX-0002LY-01; Thu, 30 Mar 2023 13:32:57 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id BF819C1DC7; Thu, 30 Mar 2023 13:30:53 +0200 (CEST) Date: Thu, 30 Mar 2023 13:30:53 +0200 From: Thomas Bogendoerfer To: Keguang Zhang Cc: linux-watchdog@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , Yang Ling Subject: Re: [PATCH 1/2] MIPS: Loongson32: Remove reset.c Message-ID: <20230330113053.GB9674@alpha.franken.de> References: <20230330102013.545588-1-keguang.zhang@gmail.com> <20230330102013.545588-2-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330102013.545588-2-keguang.zhang@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 06:20:12PM +0800, Keguang Zhang wrote: > The Loongson-1 restart handler will be moved to watchdog driver, > then _machine_restart is no longer needed. > The _machine_halt and pm_power_off are also unnecessary, > which contain no hardware operations. > > Therefore, remove the entire reset.c and related header file. > Update the Makefile accordingly. > > Signed-off-by: Keguang Zhang > --- > .../include/asm/mach-loongson32/regs-wdt.h | 15 ------ > arch/mips/loongson32/common/Makefile | 2 +- > arch/mips/loongson32/common/reset.c | 51 ------------------- > 3 files changed, 1 insertion(+), 67 deletions(-) > delete mode 100644 arch/mips/include/asm/mach-loongson32/regs-wdt.h > delete mode 100644 arch/mips/loongson32/common/reset.c Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]