From: Lee Jones <lee@kernel.org>
To: Tom Rix <trix@redhat.com>
Cc: tony@atomide.com, nathan@kernel.org, ndesaulniers@google.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] mfd: twl-core: remove unused add_child and add_numbered_child functions
Date: Thu, 30 Mar 2023 13:35:00 +0100 [thread overview]
Message-ID: <20230330123500.GG434339@google.com> (raw)
In-Reply-To: <20230322115838.2569414-1-trix@redhat.com>
On Wed, 22 Mar 2023, Tom Rix wrote:
> clang with W=1 reports
> drivers/mfd/twl-core.c:654:30: error: unused function 'add_child' [-Werror,-Wunused-function]
> static inline struct device *add_child(unsigned mod_no, const char *name,
> ^
> add_numbered_child and its only caller add_child are not used, so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/mfd/twl-core.c | 65 ------------------------------------------
> 1 file changed, 65 deletions(-)
I chopped around the commit message a bit and:
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-03-30 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:58 [PATCH] mfd: twl-core: remove unused add_child and add_numbered_child functions Tom Rix
2023-03-30 12:35 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330123500.GG434339@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tony@atomide.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox