* [PATCH] mfd: omap-usb-tll: remove unused usbtll_readb function
@ 2023-03-22 12:58 Tom Rix
2023-03-30 12:36 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-22 12:58 UTC (permalink / raw)
To: tony, lee, nathan, ndesaulniers; +Cc: linux-omap, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/mfd/omap-usb-tll.c:128:18: error: unused function
'usbtll_readb' [-Werror,-Wunused-function]
static inline u8 usbtll_readb(void __iomem *base, u32 reg)
^
This function is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/mfd/omap-usb-tll.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 8ca4067da6cd..69cbc2097911 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -125,11 +125,6 @@ static inline void usbtll_writeb(void __iomem *base, u32 reg, u8 val)
writeb_relaxed(val, base + reg);
}
-static inline u8 usbtll_readb(void __iomem *base, u32 reg)
-{
- return readb_relaxed(base + reg);
-}
-
/*-------------------------------------------------------------------------*/
static bool is_ohci_port(enum usbhs_omap_port_mode pmode)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: omap-usb-tll: remove unused usbtll_readb function
2023-03-22 12:58 [PATCH] mfd: omap-usb-tll: remove unused usbtll_readb function Tom Rix
@ 2023-03-30 12:36 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-03-30 12:36 UTC (permalink / raw)
To: Tom Rix; +Cc: tony, nathan, ndesaulniers, linux-omap, linux-kernel, llvm
On Wed, 22 Mar 2023, Tom Rix wrote:
> clang with W=1 reports
> drivers/mfd/omap-usb-tll.c:128:18: error: unused function
> 'usbtll_readb' [-Werror,-Wunused-function]
> static inline u8 usbtll_readb(void __iomem *base, u32 reg)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/mfd/omap-usb-tll.c | 5 -----
> 1 file changed, 5 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-30 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-22 12:58 [PATCH] mfd: omap-usb-tll: remove unused usbtll_readb function Tom Rix
2023-03-30 12:36 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox