* [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370_RGB
@ 2023-03-23 10:54 Lukas Bulwahn
2023-03-23 11:06 ` Pavel Machek
2023-03-30 12:43 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2023-03-23 10:54 UTC (permalink / raw)
To: Alice Chen, ChiYuan Huang, ChiaEn Wu, Jacek Anaszewski,
Pavel Machek, Lee Jones, linux-leds
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink
type LED Indicator support") introduces the config LEDS_MT6370_RGB, which
selects the non-existing config LINEAR_RANGE. As the driver includes
linux/linear_range.h, it is a safe guess that the config actually intends
to select LINEAR_RANGES, which provides the library implementation for the
function prototypes defined in the linear_range header file.
Correct this naming confusion in the LEDS_MT6370_RGB config definition.
Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/leds/rgb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 7d86bb26c54b..360c8679c6e2 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
config LEDS_MT6370_RGB
tristate "LED Support for MediaTek MT6370 PMIC"
depends on MFD_MT6370
- select LINEAR_RANGE
+ select LINEAR_RANGES
help
Say Y here to enable support for MT6370_RGB LED device.
In MT6370, there are four channel current-sink LED drivers that
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370_RGB
2023-03-23 10:54 [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370_RGB Lukas Bulwahn
@ 2023-03-23 11:06 ` Pavel Machek
2023-03-30 12:43 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2023-03-23 11:06 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Alice Chen, ChiYuan Huang, ChiaEn Wu, Jacek Anaszewski, Lee Jones,
linux-leds, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
Hi!
> Commit 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink
> type LED Indicator support") introduces the config LEDS_MT6370_RGB, which
> selects the non-existing config LINEAR_RANGE. As the driver includes
> linux/linear_range.h, it is a safe guess that the config actually intends
> to select LINEAR_RANGES, which provides the library implementation for the
> function prototypes defined in the linear_range header file.
>
> Correct this naming confusion in the LEDS_MT6370_RGB config
> definition.
Looks good.
Acked-by: Pavel Machek <pavel@ucw.cz>
Best regards,
Pavel
> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
> config LEDS_MT6370_RGB
> tristate "LED Support for MediaTek MT6370 PMIC"
> depends on MFD_MT6370
> - select LINEAR_RANGE
> + select LINEAR_RANGES
> help
> Say Y here to enable support for MT6370_RGB LED device.
> In MT6370, there are four channel current-sink LED drivers that
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370_RGB
2023-03-23 10:54 [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370_RGB Lukas Bulwahn
2023-03-23 11:06 ` Pavel Machek
@ 2023-03-30 12:43 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-03-30 12:43 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Alice Chen, ChiYuan Huang, ChiaEn Wu, Jacek Anaszewski,
Pavel Machek, linux-leds, kernel-janitors, linux-kernel
On Thu, 23 Mar 2023, Lukas Bulwahn wrote:
> Commit 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink
> type LED Indicator support") introduces the config LEDS_MT6370_RGB, which
> selects the non-existing config LINEAR_RANGE. As the driver includes
> linux/linear_range.h, it is a safe guess that the config actually intends
> to select LINEAR_RANGES, which provides the library implementation for the
> function prototypes defined in the linear_range header file.
>
> Correct this naming confusion in the LEDS_MT6370_RGB config definition.
>
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/leds/rgb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-30 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-23 10:54 [PATCH] leds: rgb: mt6370: correct config name to select in LEDS_MT6370_RGB Lukas Bulwahn
2023-03-23 11:06 ` Pavel Machek
2023-03-30 12:43 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox