Re: [PATCH tty-next 2/2] serial: 8250: add driver for NI UARTs

Ilpo Järvinen
2023-04-05T10:17:47Z

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Fri, 31 Mar 2023, Brenda Streiff wrote:

> On 3/31/23 06:46, Ilpo Järvinen wrote:
> > On Wed, 29 Mar 2023, Brenda Streiff wrote:
>
> > > + int irq;
> > > + int rs232_property = 0;
> > > + unsigned int prescaler;
> > > + const char *transceiver;
> > > + int txfifosz, rxfifosz;
> >
> > Try to follow reverse xmas-tree order.
>
> Is reverse xmas tree also the rule in the tty subsystem? I was aware of
> it for netdev but I thought that was a netdev-specific rule (since it
> only shows up in maintainer-netdev.rst and not more broadly)

I'd say that not as strictly as e.g. netdev does so if e.g. due to
initialization order it cannot be fully achieved no special trickery is
required (in contrast to what you'd get from e.g. netdev telling to put
them out of line).

It seems generally useful for declarations, especially when they're as
many as in the one I picked up above (I think might be due to less eye
movement required when looking for a particular variable by its name).

--
i.