Re: [PATCH tty-next 1/2] dt-bindings: serial: ni,ni16650: add bindings

Krzysztof Kozlowski
2023-03-31T20:01:07Z

On 31/03/2023 19:59, Brenda Streiff wrote:
>
>
> On 3/30/23 02:28, Krzysztof Kozlowski wrote
>>> + - enum:
>>> + - ni,ni16550
>>
>> As Rob pointed out - you did not test it at all.
>>
>
> I did, with dt-schema 2023.1 and the 'make dt_binding_check' command as
> described in Documentation/devicetree/bindings/writing-schema.rst
> (with no DT_CHECKER_FLAGS, because I was unaware of it until Rob's post)

No need to use it...

>
> Is this a documentation gap, or is the DT_CHECKER_FLAGS option slated to
> become the default for 'make dt_binding_check' in the future?

You shouldn't need any flags. Regular testing shows errors:

ni,ni16550.example.dtb: serial@80000000: compatible: 'oneOf' conditional
failed, one must be fixed:
['ni,ni16550', 'ns16550a'] is too long
['ni,ni16550', 'ns16550a'] is too short

Best regards,
Krzysztof