From: Lee Jones <lee@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, ChiYuan Huang <cy_huang@richtek.com>,
Arnd Bergmann <arnd@arndb.de>,
Alice Chen <alice_chen@richtek.com>,
Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select
Date: Thu, 30 Mar 2023 18:05:33 +0100 [thread overview]
Message-ID: <20230330170533.GA548901@google.com> (raw)
In-Reply-To: <20230328131222.1390091-1-arnd@kernel.org>
On Tue, 28 Mar 2023, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> CONFIG_LINEAR_RANGE does not exist, but selecting is silently ignored.
>
> ERROR: modpost: "linear_range_get_selector_within" [drivers/leds/rgb/leds-mt6370-rgb.ko] undefined!
>
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/leds/rgb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Beaten to it I'm afraid:
https://lore.kernel.org/r/20230323105410.10396-1-lukas.bulwahn@gmail.com
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 7d86bb26c54b..360c8679c6e2 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
> config LEDS_MT6370_RGB
> tristate "LED Support for MediaTek MT6370 PMIC"
> depends on MFD_MT6370
> - select LINEAR_RANGE
> + select LINEAR_RANGES
> help
> Say Y here to enable support for MT6370_RGB LED device.
> In MT6370, there are four channel current-sink LED drivers that
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-03-30 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 13:11 [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select Arnd Bergmann
2023-03-30 2:41 ` Randy Dunlap
2023-03-30 17:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330170533.GA548901@google.com \
--to=lee@kernel.org \
--cc=alice_chen@richtek.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sven.schwermer@disruptive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox