* [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select
@ 2023-03-28 13:11 Arnd Bergmann
2023-03-30 2:41 ` Randy Dunlap
2023-03-30 17:05 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-03-28 13:11 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, ChiYuan Huang
Cc: Arnd Bergmann, Alice Chen, Sven Schwermer, Jacek Anaszewski,
ChiaEn Wu, linux-leds, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
CONFIG_LINEAR_RANGE does not exist, but selecting is silently ignored.
ERROR: modpost: "linear_range_get_selector_within" [drivers/leds/rgb/leds-mt6370-rgb.ko] undefined!
Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/rgb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 7d86bb26c54b..360c8679c6e2 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
config LEDS_MT6370_RGB
tristate "LED Support for MediaTek MT6370 PMIC"
depends on MFD_MT6370
- select LINEAR_RANGE
+ select LINEAR_RANGES
help
Say Y here to enable support for MT6370_RGB LED device.
In MT6370, there are four channel current-sink LED drivers that
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select
2023-03-28 13:11 [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select Arnd Bergmann
@ 2023-03-30 2:41 ` Randy Dunlap
2023-03-30 17:05 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-03-30 2:41 UTC (permalink / raw)
To: Arnd Bergmann, Pavel Machek, Lee Jones, ChiYuan Huang
Cc: Arnd Bergmann, Alice Chen, Sven Schwermer, Jacek Anaszewski,
ChiaEn Wu, linux-leds, linux-kernel
On 3/28/23 06:11, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> CONFIG_LINEAR_RANGE does not exist, but selecting is silently ignored.
>
> ERROR: modpost: "linear_range_get_selector_within" [drivers/leds/rgb/leds-mt6370-rgb.ko] undefined!
>
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/leds/rgb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 7d86bb26c54b..360c8679c6e2 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
> config LEDS_MT6370_RGB
> tristate "LED Support for MediaTek MT6370 PMIC"
> depends on MFD_MT6370
> - select LINEAR_RANGE
> + select LINEAR_RANGES
> help
> Say Y here to enable support for MT6370_RGB LED device.
> In MT6370, there are four channel current-sink LED drivers that
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select
2023-03-28 13:11 [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select Arnd Bergmann
2023-03-30 2:41 ` Randy Dunlap
@ 2023-03-30 17:05 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-03-30 17:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Pavel Machek, ChiYuan Huang, Arnd Bergmann, Alice Chen,
Sven Schwermer, Jacek Anaszewski, ChiaEn Wu, linux-leds,
linux-kernel
On Tue, 28 Mar 2023, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> CONFIG_LINEAR_RANGE does not exist, but selecting is silently ignored.
>
> ERROR: modpost: "linear_range_get_selector_within" [drivers/leds/rgb/leds-mt6370-rgb.ko] undefined!
>
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/leds/rgb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Beaten to it I'm afraid:
https://lore.kernel.org/r/20230323105410.10396-1-lukas.bulwahn@gmail.com
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 7d86bb26c54b..360c8679c6e2 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
> config LEDS_MT6370_RGB
> tristate "LED Support for MediaTek MT6370 PMIC"
> depends on MFD_MT6370
> - select LINEAR_RANGE
> + select LINEAR_RANGES
> help
> Say Y here to enable support for MT6370_RGB LED device.
> In MT6370, there are four channel current-sink LED drivers that
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-30 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-28 13:11 [PATCH] leds: rgb: mt6370: fix CONFIG_LINEAR_RANGES select Arnd Bergmann
2023-03-30 2:41 ` Randy Dunlap
2023-03-30 17:05 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox