* [PATCH] MFD: dln2: fix memory leak in dln2_probe
@ 2023-03-30 2:43 Qiang Ning
2023-03-30 17:07 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Qiang Ning @ 2023-03-30 2:43 UTC (permalink / raw)
To: lee, qning0106; +Cc: linux-kernel
When dln2_setup_rx_urbs() in dln2_probe() fails, error out_free
forgets to call usb_put_dev to decrease the refcount of
dln2->usb_dev.
Fix this by adding usb_put_dev() in the error handling code
of dln2_probe().
Signed-off-by: Qiang Ning <qning0106@126.com>
---
drivers/mfd/dln2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
index 6cd0b0c752d6..c3149729cec2 100644
--- a/drivers/mfd/dln2.c
+++ b/drivers/mfd/dln2.c
@@ -827,6 +827,7 @@ static int dln2_probe(struct usb_interface *interface,
dln2_stop_rx_urbs(dln2);
out_free:
+ usb_put_dev(dln2->usb_dev);
dln2_free(dln2);
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MFD: dln2: fix memory leak in dln2_probe
2023-03-30 2:43 [PATCH] MFD: dln2: fix memory leak in dln2_probe Qiang Ning
@ 2023-03-30 17:07 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-03-30 17:07 UTC (permalink / raw)
To: Qiang Ning; +Cc: linux-kernel
On Thu, 30 Mar 2023, Qiang Ning wrote:
> When dln2_setup_rx_urbs() in dln2_probe() fails, error out_free
> forgets to call usb_put_dev to decrease the refcount of
> dln2->usb_dev.
>
> Fix this by adding usb_put_dev() in the error handling code
> of dln2_probe().
>
> Signed-off-by: Qiang Ning <qning0106@126.com>
> ---
> drivers/mfd/dln2.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-30 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-30 2:43 [PATCH] MFD: dln2: fix memory leak in dln2_probe Qiang Ning
2023-03-30 17:07 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox