From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nikita Travkin <nikita@trvn.ru>,
Stephan Gerhold <stephan@gerhold.net>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/2] dt-bindings: leds: aw2013: Document vdd-supply
Date: Thu, 30 Mar 2023 18:18:51 +0100 [thread overview]
Message-ID: <20230330171851.GE548901@google.com> (raw)
In-Reply-To: <5eb0b699-47bb-ebb7-2ea5-0cf05ccf29ab@linaro.org>
On Thu, 30 Mar 2023, Krzysztof Kozlowski wrote:
> On 30/03/2023 13:46, Lee Jones wrote:
> > On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote:
> >
> >> On 20/03/2023 15:22, Lin, Meng-Bo wrote:
> >>> Document vdd-supply, a regulator providing power to the "VDD" pin.
> >>>
> >>
> >> No. This device does not have VDD pin. I checked in datasheet.
> >
> > I'm confused. This patch set much do something?
> >
> > I guess a better commit message would help. Let me request that.
>
> There was a v2 - with a discussion - so we wait for v3 which clearly
> indicates this is supply on controller side. IMHO, this is still wrong
> because it is controller's property, not device's, but Rob gave here
> green light, so v3 with proper explanation would be fine.
Understood, thanks.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-30 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 14:20 [PATCH 0/2] leds: aw2013: Add vdd regulator Lin, Meng-Bo
2023-03-20 14:22 ` [PATCH 1/2] dt-bindings: leds: aw2013: Document vdd-supply Lin, Meng-Bo
2023-03-20 16:44 ` Krzysztof Kozlowski
2023-03-30 11:46 ` Lee Jones
2023-03-30 13:44 ` Krzysztof Kozlowski
2023-03-30 17:18 ` Lee Jones [this message]
2023-03-20 14:22 ` [PATCH 2/2] leds: aw2013: Add vdd regulator Lin, Meng-Bo
2023-03-30 11:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330171851.GE548901@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linmengbo0689@protonmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox