From: David Vernet <void@manifault.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: [PATCH bpf-next 0/3] Enable RCU semantics for task kptrs
Date: Thu, 30 Mar 2023 19:57:30 -0500 [thread overview]
Message-ID: <20230331005733.406202-1-void@manifault.com> (raw)
In commit 22df776a9a86 ("tasks: Extract rcu_users out of union"), the
'refcount_t rcu_users' field was extracted out of a union with the
'struct rcu_head rcu' field. This allows us to use the field for
refcounting struct task_struct with RCU protection, as the RCU callback
no longer flips rcu_users to be nonzero after the callback is scheduled.
This patch set leverages this to do a few things:
1. Marks struct task_struct as RCU safe in the verifier, allowing
referenced kptr tasks stored in maps to be accessed in an RCU
read region without acquiring a reference (with just a NULL check).
2. Makes bpf_task_acquire() a KF_ACQUIRE | KF_RCU | KF_RET_NULL kfunc.
3. Removes bpf_task_kptr_get() and bpf_task_acquire_not_zero(), as
they're now redundant with the above two changes.
4. Updates selftests and documentation accordingly.
David Vernet (3):
bpf: Make struct task_struct an RCU-safe type
bpf: Remove now-defunct task kfuncs
bpf,docs: Update documentation to reflect new task kfuncs
Documentation/bpf/kfuncs.rst | 49 ++++++-
kernel/bpf/helpers.c | 78 +----------
kernel/bpf/verifier.c | 1 +
.../selftests/bpf/prog_tests/task_kfunc.c | 4 +-
.../selftests/bpf/progs/rcu_read_lock.c | 9 +-
.../selftests/bpf/progs/task_kfunc_common.h | 6 +-
.../selftests/bpf/progs/task_kfunc_failure.c | 126 ++++++++----------
.../selftests/bpf/progs/task_kfunc_success.c | 76 +++++++++--
8 files changed, 174 insertions(+), 175 deletions(-)
--
2.39.0
next reply other threads:[~2023-03-31 0:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 0:57 David Vernet [this message]
2023-03-31 0:57 ` [PATCH bpf-next 1/3] bpf: Make struct task_struct an RCU-safe type David Vernet
2023-03-31 17:05 ` Alexei Starovoitov
2023-03-31 17:35 ` David Vernet
2023-03-31 17:49 ` Alexei Starovoitov
2023-03-31 0:57 ` [PATCH bpf-next 2/3] bpf: Remove now-defunct task kfuncs David Vernet
2023-03-31 0:57 ` [PATCH bpf-next 3/3] bpf,docs: Update documentation to reflect new " David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331005733.406202-1-void@manifault.com \
--to=void@manifault.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox