From: David Gow <davidgow@google.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Maxime Ripard <maxime@cerno.tech>,
Brendan Higgins <brendan.higgins@linux.dev>,
Stephen Boyd <sboyd@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Daniel Latypov <dlatypov@google.com>, Rae Moar <rmoar@google.com>,
Benjamin Berg <benjamin@sipsolutions.net>
Cc: David Gow <davidgow@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com
Subject: [RFC PATCH v2 2/3] kunit: executor_test: Use kunit_add_action()
Date: Fri, 31 Mar 2023 16:04:10 +0800 [thread overview]
Message-ID: <20230331080411.981038-3-davidgow@google.com> (raw)
In-Reply-To: <20230331080411.981038-1-davidgow@google.com>
Now we have the kunit_add_action() function, we can use it to implement
kfree_at_end() and free_subsuite_at_end() without the need for extra
helper functions.
Signed-off-by: David Gow <davidgow@google.com>
---
lib/kunit/executor_test.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c
index 0cea31c27b23..e0b9d945c6e5 100644
--- a/lib/kunit/executor_test.c
+++ b/lib/kunit/executor_test.c
@@ -125,11 +125,6 @@ kunit_test_suites(&executor_test_suite);
/* Test helpers */
-static void kfree_res_free(struct kunit_resource *res)
-{
- kfree(res->data);
-}
-
/* Use the resource API to register a call to kfree(to_free).
* Since we never actually use the resource, it's safe to use on const data.
*/
@@ -138,8 +133,11 @@ static void kfree_at_end(struct kunit *test, const void *to_free)
/* kfree() handles NULL already, but avoid allocating a no-op cleanup. */
if (IS_ERR_OR_NULL(to_free))
return;
- kunit_alloc_resource(test, NULL, kfree_res_free, GFP_KERNEL,
- (void *)to_free);
+
+ kunit_add_action(test,
+ (kunit_defer_function_t)kfree,
+ (void *)to_free,
+ GFP_KERNEL);
}
static struct kunit_suite *alloc_fake_suite(struct kunit *test,
--
2.40.0.348.gf938b09366-goog
next prev parent reply other threads:[~2023-03-31 8:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 8:04 [RFC PATCH v2 0/3] kunit: Deferred action helpers David Gow
2023-03-31 8:04 ` [RFC PATCH v2 1/3] kunit: Add kunit_add_action() to defer a call until test exit David Gow
2023-04-04 13:32 ` Maxime Ripard
2023-04-04 17:55 ` Benjamin Berg
2023-04-05 8:09 ` David Gow
2023-04-05 7:47 ` David Gow
2023-04-14 9:53 ` Maxime Ripard
2023-04-14 10:01 ` maxime
2023-04-14 11:00 ` Benjamin Berg
2023-04-14 11:33 ` Maxime Ripard
2023-04-15 8:48 ` David Gow
2023-04-15 8:42 ` David Gow
2023-04-17 11:07 ` Maxime Ripard
2023-03-31 8:04 ` David Gow [this message]
2023-03-31 8:04 ` [RFC PATCH v2 3/3] kunit: kmalloc_array: Use kunit_add_action() David Gow
2023-04-04 17:58 ` Benjamin Berg
2023-04-05 7:48 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331080411.981038-3-davidgow@google.com \
--to=davidgow@google.com \
--cc=benjamin@sipsolutions.net \
--cc=brendan.higgins@linux.dev \
--cc=dlatypov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mazziesaccount@gmail.com \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox