From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Matthew Auld <matthew.auld@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 09/19] drm/i915/gem/i915_gem_ttm_pm: Provide a couple of missing descriptions for 'flags' and remove some superfluous ones
Date: Fri, 31 Mar 2023 10:25:57 +0100 [thread overview]
Message-ID: <20230331092607.700644-10-lee@kernel.org> (raw)
In-Reply-To: <20230331092607.700644-1-lee@kernel.org>
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Function parameter or member 'flags' not described in 'i915_ttm_backup_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_backup_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'backup_pinned' description in 'i915_ttm_backup_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:223: warning: Function parameter or member 'flags' not described in 'i915_ttm_restore_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:223: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_restore_region'
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index dfe39c8e74d8a..ad649523d5e0b 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
@@ -144,8 +144,7 @@ void i915_ttm_recover_region(struct intel_memory_region *mr)
/**
* i915_ttm_backup_region - Back up all objects of a region to smem.
* @mr: The memory region
- * @allow_gpu: Whether to allow the gpu blitter for this backup.
- * @backup_pinned: Backup also pinned objects.
+ * @flags: TTM backup flags
*
* Loops over all objects of a region and either evicts them if they are
* evictable or backs them up using a backup object if they are pinned.
@@ -212,7 +211,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
/**
* i915_ttm_restore_region - Restore backed-up objects of a region from smem.
* @mr: The memory region
- * @allow_gpu: Whether to allow the gpu blitter to recover.
+ * @flags: TTM backup flags
*
* Loops over all objects of a region and if they are backed-up, restores
* them from smem.
--
2.40.0.348.gf938b09366-goog
next prev parent reply other threads:[~2023-03-31 9:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:25 [PATCH (set 2) 00/19] Rid W=1 warnings from GPU Lee Jones
2023-03-31 9:25 ` [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@' Lee Jones
2023-04-03 15:35 ` Jani Nikula
2023-04-03 16:20 ` Lee Jones
2023-04-04 9:44 ` Jani Nikula
2023-04-05 13:45 ` Lee Jones
2023-04-05 16:06 ` Jani Nikula
2023-04-05 16:41 ` Lee Jones
2023-03-31 9:25 ` [PATCH 02/19] drm/i915/intel_region_ttm: Provide missing description for 'offset' param Lee Jones
2023-03-31 9:25 ` [PATCH 03/19] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Lee Jones
2023-03-31 9:25 ` [PATCH 04/19] drm/i915/display/intel_display_debugfs: Fix incorrect param naming for 'intel_connector' Lee Jones
2023-03-31 9:25 ` [PATCH 05/19] drm/i915/gt/intel_engine_cs: Fix a couple of incorrectly named functions Lee Jones
2023-03-31 9:25 ` [PATCH 06/19] drm/i915/gt/intel_rps: Demote a kerneldoc abuse for ips_ping_for_i915_load() Lee Jones
2023-03-31 9:25 ` [PATCH 07/19] drm/i915/gem/i915_gem_create: Provide the function names for proper kerneldoc headers Lee Jones
2023-03-31 15:18 ` kernel test robot
2023-03-31 9:25 ` [PATCH 08/19] drm/i915/gem/i915_gem_domain: Provide function names to complete proper kerneldoc Lee Jones
2023-03-31 9:25 ` Lee Jones [this message]
2023-03-31 9:25 ` [PATCH 10/19] drm/i915/gem/i915_gem_ttm: Demote half-filled kerneldoc Lee Jones
2023-03-31 9:25 ` [PATCH 11/19] drm/i915/gem/i915_gem_ttm_move: Provide a couple of missing descriptions for 'num_pages' and 'ctx' Lee Jones
2023-03-31 9:26 ` [PATCH 12/19] drm/i915/gem/i915_gem_wait: Provide function name to validate the kerneldoc header Lee Jones
2023-03-31 9:26 ` [PATCH 13/19] drm/i915/gem/i915_gem_object: Demote non-kerneldoc header with no param descriptions Lee Jones
2023-03-31 9:26 ` [PATCH 14/19] drm/i915/i915_gem: Provide function names to complete the expected kerneldoc format Lee Jones
2023-03-31 17:52 ` kernel test robot
2023-03-31 9:26 ` [PATCH 15/19] drm/i915/gt/uc/intel_guc_hwconfig: Demote a few non-conforming kerneldoc headers Lee Jones
2023-03-31 9:26 ` [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header Lee Jones
2023-03-31 9:26 ` [PATCH 17/19] drm/i915/display/intel_display_power: Fix incorrectly documented function __intel_display_power_put_async() Lee Jones
2023-03-31 9:26 ` [PATCH 18/19] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Lee Jones
2023-03-31 9:26 ` [PATCH 19/19] drm/i915/display/intel_wm: Fix a little doc-rot in intel_update_watermarks() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331092607.700644-10-lee@kernel.org \
--to=lee@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).