public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH 5/7] driver core: class: remove dev_kobj from struct class
Date: Fri, 31 Mar 2023 11:33:16 +0200	[thread overview]
Message-ID: <20230331093318.82288-5-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20230331093318.82288-1-gregkh@linuxfoundation.org>

The dev_kobj field in struct class is now only written to, but never
read from, so it can be removed as it is useless.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 block/genhd.c                | 1 -
 drivers/base/class.c         | 4 ----
 include/linux/device/class.h | 2 --
 3 files changed, 7 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index e1e1230b1b9f..af7208a37c53 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -899,7 +899,6 @@ static int __init genhd_device_init(void)
 {
 	int error;
 
-	block_class.dev_kobj = sysfs_dev_block_kobj;
 	error = class_register(&block_class);
 	if (unlikely(error))
 		return error;
diff --git a/drivers/base/class.c b/drivers/base/class.c
index fcfb295363cc..06b96d6faa19 100644
--- a/drivers/base/class.c
+++ b/drivers/base/class.c
@@ -197,10 +197,6 @@ int class_register(struct class *cls)
 		return error;
 	}
 
-	/* set the default /sys/dev directory for devices of this class */
-	if (!cls->dev_kobj)
-		cls->dev_kobj = sysfs_dev_char_kobj;
-
 	cp->subsys.kobj.kset = class_kset;
 	cp->subsys.kobj.ktype = &class_ktype;
 	cp->class = cls;
diff --git a/include/linux/device/class.h b/include/linux/device/class.h
index f7aad64e256a..e946642c314e 100644
--- a/include/linux/device/class.h
+++ b/include/linux/device/class.h
@@ -27,7 +27,6 @@ struct fwnode_handle;
  * @name:	Name of the class.
  * @class_groups: Default attributes of this class.
  * @dev_groups:	Default attributes of the devices that belong to the class.
- * @dev_kobj:	The kobject that represents this class and links it into the hierarchy.
  * @dev_uevent:	Called when a device is added, removed from this class, or a
  *		few other things that generate uevents to add the environment
  *		variables.
@@ -55,7 +54,6 @@ struct class {
 
 	const struct attribute_group	**class_groups;
 	const struct attribute_group	**dev_groups;
-	struct kobject			*dev_kobj;
 
 	int (*dev_uevent)(const struct device *dev, struct kobj_uevent_env *env);
 	char *(*devnode)(const struct device *dev, umode_t *mode);
-- 
2.40.0


  parent reply	other threads:[~2023-03-31  9:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  9:33 [PATCH 1/7] driver core: core: move to use class_to_subsys() Greg Kroah-Hartman
2023-03-31  9:33 ` [PATCH 2/7] driver core: create class_is_registered() Greg Kroah-Hartman
2023-03-31 10:16   ` Rafael J. Wysocki
2023-03-31 12:44   ` Linus Walleij
2023-03-31  9:33 ` [PATCH 3/7] driver core: class: remove subsystem private pointer from struct class Greg Kroah-Hartman
2023-03-31 14:48   ` Rafael J. Wysocki
2023-03-31  9:33 ` [PATCH 4/7] driver core: clean up the logic to determine which /sys/dev/ directory to use Greg Kroah-Hartman
2023-03-31 14:49   ` Rafael J. Wysocki
2023-03-31  9:33 ` Greg Kroah-Hartman [this message]
2023-03-31 14:50   ` [PATCH 5/7] driver core: class: remove dev_kobj from struct class Rafael J. Wysocki
2023-03-31  9:33 ` [PATCH 6/7] driver core: make sysfs_dev_block_kobj static Greg Kroah-Hartman
2023-03-31 14:50   ` Rafael J. Wysocki
2023-03-31  9:33 ` [PATCH 7/7] driver core: make sysfs_dev_char_kobj static Greg Kroah-Hartman
2023-03-31 14:50   ` Rafael J. Wysocki
2023-03-31 10:26 ` [PATCH 1/7] driver core: core: move to use class_to_subsys() Rafael J. Wysocki
2023-03-31 15:44   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331093318.82288-5-gregkh@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox