Re: [PATCH v3 15/55] ip, udp: Support MSG_SPLICE_PAGES

Willem de Bruijn
2023-04-04T17:36:41Z

David Howells wrote:
> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>
> > > Okay. How about the attached? This seems to work. Just setting "paged" to
> > > true seems to do the right thing in __ip_append_data() when allocating /
> > > setting up the skbuff, and then __ip_splice_pages() is called to add the
> > > pages.
> >
> > If this works, much preferred. Looks great to me.
>
> :-)
>
> > As said, then __ip_splice_pages() probably no longer needs the
> > preamble to copy initial header bytes.
>
> Sorry, what? It only attaches pages extracted from the iterator.

Ehm indeed. Never mind.