RE: [PATCH v3 03/55] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag

Willem de Bruijn
2023-04-02T14:56:58Z

David Howells wrote:
> Declare MSG_SPLICE_PAGES, an internal sendmsg() flag, that hints to a
> network protocol that it should splice pages from the source iterator
> rather than copying the data if it can. This flag is added to a list that
> is cleared by sendmsg and recvmsg syscalls on entry.

nit: comment not longer matches implementation: recvmsg

> This is intended as a replacement for the ->sendpage() op, allowing a way
> to splice in several multipage folios in one go.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> cc: "David S. Miller" <davem@davemloft.net>
> cc: Eric Dumazet <edumazet@google.com>
> cc: Jakub Kicinski <kuba@kernel.org>
> cc: Paolo Abeni <pabeni@redhat.com>
> cc: Jens Axboe <axboe@kernel.dk>
> cc: Matthew Wilcox <willy@infradead.org>
> cc: netdev@vger.kernel.org

Aside from that

Reviewed-by: Willem de Bruijn <willemb@google.com>