Re: [PATCH net-next v3 07/12] net: stmmac: Remove some unnecessary void pointers

Simon Horman
2023-04-01T14:49:52Z

On Fri, Mar 31, 2023 at 04:45:44PM -0500, Andrew Halaney wrote:
> There's a few spots in the hardware interface where a void pointer is
> used, but what's passed in and later cast out is always the same type.
>
> Just use the proper type directly.
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
>
> Changes since v2:
> * New patch. In later patches refactoring hwif.h I touched these in
> their first form (which was later dropped) and changed this as
> part of that. But I thought the change was still good overall,
> so I left this improvement in the series.

FWIIW, I am very pleased to see this kind of change.

Reviewed-by: Simon Horman <simon.horman@corigine.com>