From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F53C761A6 for ; Sat, 1 Apr 2023 01:45:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233663AbjDABpL (ORCPT ); Fri, 31 Mar 2023 21:45:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233746AbjDABo0 (ORCPT ); Fri, 31 Mar 2023 21:44:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AAC123687; Fri, 31 Mar 2023 18:43:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 63EA4B83312; Sat, 1 Apr 2023 01:42:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FBF6C4339E; Sat, 1 Apr 2023 01:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680313378; bh=wYI/r4tJiEhg6thiFHAvKr41kMTWCFXFYIv/1bsrBcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aaO3wx5YcL7qtkY+UUFI9ESiPSe1OC+xLBqHFH2PKokjRdekWuAKItk55Bfy8B6we GwC7HDfARVx3Gwzzdz+5UvPw1IsBaKyd4M9WazxJ1U7glT8fyC6eFHtdRlS3Ep9wrl 4KtHOyZgLZKNDxVbjGLLxCPBaLYuz6Bsm3URH1HFSSvKKFUKEHIYO3SRQJXgu02MK4 NQ9qPocOCi6ZkrQ9gC0x7goV3MAnQU53uAzZlsYpvNzTBG7SZVcowsULogUNfZtE3q 9T3DcNBksmxJufrS/IkTds7mSyoXT17LtV5qgx48Sr6samPsZI6qDjLn+doxik/bX1 mFGuzcxag2k/Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yicong Yang , Sheng Feng , Wolfram Sang , Sasha Levin , linux-i2c@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 09/24] i2c: hisi: Avoid redundant interrupts Date: Fri, 31 Mar 2023 21:42:25 -0400 Message-Id: <20230401014242.3356780-9-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401014242.3356780-1-sashal@kernel.org> References: <20230401014242.3356780-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yicong Yang [ Upstream commit cc9812a3096d1986caca9a23bee99effc45c08df ] After issuing all the messages we can disable the TX_EMPTY interrupts to avoid handling redundant interrupts. For doing a sinlge bus detection (i2cdetect -y -r 0) we can reduce ~97% interrupts (before ~12000 after ~400). Signed-off-by: Sheng Feng Signed-off-by: Yicong Yang Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-hisi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c index d30071f299879..8a61bee745a16 100644 --- a/drivers/i2c/busses/i2c-hisi.c +++ b/drivers/i2c/busses/i2c-hisi.c @@ -314,6 +314,13 @@ static void hisi_i2c_xfer_msg(struct hisi_i2c_controller *ctlr) max_write == 0) break; } + + /* + * Disable the TX_EMPTY interrupt after finishing all the messages to + * avoid overwhelming the CPU. + */ + if (ctlr->msg_tx_idx == ctlr->msg_num) + hisi_i2c_disable_int(ctlr, HISI_I2C_INT_TX_EMPTY); } static irqreturn_t hisi_i2c_irq(int irq, void *context) -- 2.39.2