From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: addac: stx104: Migrate to the regmap API
Date: Sun, 2 Apr 2023 17:46:57 +0100 [thread overview]
Message-ID: <20230402174657.55159879@jic23-huawei> (raw)
In-Reply-To: <ZCg6bhkxGKmkMloM@fedora>
> > > + .wr_table = &aio_ctl_wr_table,
> > > + .rd_table = &aio_ctl_rd_table,
> > > + .volatile_table = &aio_ctl_volatile_table,
> > > + .cache_type = REGCACHE_FLAT,
> > > +};
> >
> > Do we need regmap lock?
>
> I think the regmap lock is opt-out, so I don't think we need to set an
> custom lock callback for the regmaps in this driver.
>
> Jonathan, do read_raw() and write_raw() require explicit locking?
The don't provide their own locking. Depending on the access pattern the
underlying bus locking may be sufficient. If you have read modify write
cycles though you'll want locking at the appropriate level for that
which might well be at the level of regmap.
Jonathan
next prev parent reply other threads:[~2023-04-02 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 22:05 [PATCH v3 0/2] Migrate STX104 to the regmap API William Breathitt Gray
2023-03-26 22:05 ` [PATCH v3 1/2] iio: addac: stx104: Migrate " William Breathitt Gray
2023-03-27 11:42 ` Andy Shevchenko
2023-04-01 13:49 ` Jonathan Cameron
2023-04-01 13:51 ` Jonathan Cameron
2023-04-01 13:43 ` William Breathitt Gray
2023-04-01 14:06 ` William Breathitt Gray
2023-04-02 16:46 ` Jonathan Cameron [this message]
2023-04-02 14:51 ` William Breathitt Gray
2023-03-26 22:05 ` [PATCH v3 2/2] iio: addac: stx104: Use regmap_read_poll_timeout() for conversion poll William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230402174657.55159879@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox