From: Dmitry Safonov <dima@arista.com>
To: linux-kernel@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Dmitry Safonov <dima@arista.com>,
Andy Lutomirski <luto@amacapital.net>,
Ard Biesheuvel <ardb@kernel.org>,
Bob Gilligan <gilligan@arista.com>,
Dan Carpenter <error27@gmail.com>,
David Laight <David.Laight@aculab.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Eric Biggers <ebiggers@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Ivan Delalande <colona@arista.com>,
Leonard Crestez <cdleonard@gmail.com>,
Salam Noureddine <noureddine@arista.com>,
netdev@vger.kernel.org, Francesco Ruggeri <fruggeri@arista.com>
Subject: [PATCH v5 14/21] net/tcp: Add TCP-AO SNE support
Date: Mon, 3 Apr 2023 22:34:13 +0100 [thread overview]
Message-ID: <20230403213420.1576559-15-dima@arista.com> (raw)
In-Reply-To: <20230403213420.1576559-1-dima@arista.com>
Add Sequence Number Extension (SNE) extension for TCP-AO.
This is needed to protect long-living TCP-AO connections from replaying
attacks after sequence number roll-over, see RFC5925 (6.2).
Co-developed-by: Francesco Ruggeri <fruggeri@arista.com>
Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
Co-developed-by: Salam Noureddine <noureddine@arista.com>
Signed-off-by: Salam Noureddine <noureddine@arista.com>
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
net/ipv4/tcp_input.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 9e7e5ee57137..d0a604b05518 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3528,9 +3528,21 @@ static inline bool tcp_may_update_window(const struct tcp_sock *tp,
static void tcp_snd_una_update(struct tcp_sock *tp, u32 ack)
{
u32 delta = ack - tp->snd_una;
+#ifdef CONFIG_TCP_AO
+ struct tcp_ao_info *ao;
+#endif
sock_owned_by_me((struct sock *)tp);
tp->bytes_acked += delta;
+#ifdef CONFIG_TCP_AO
+ ao = rcu_dereference_protected(tp->ao_info,
+ lockdep_sock_is_held((struct sock *)tp));
+ if (ao) {
+ if (ack < ao->snd_sne_seq)
+ ao->snd_sne++;
+ ao->snd_sne_seq = ack;
+ }
+#endif
tp->snd_una = ack;
}
@@ -3538,9 +3550,21 @@ static void tcp_snd_una_update(struct tcp_sock *tp, u32 ack)
static void tcp_rcv_nxt_update(struct tcp_sock *tp, u32 seq)
{
u32 delta = seq - tp->rcv_nxt;
+#ifdef CONFIG_TCP_AO
+ struct tcp_ao_info *ao;
+#endif
sock_owned_by_me((struct sock *)tp);
tp->bytes_received += delta;
+#ifdef CONFIG_TCP_AO
+ ao = rcu_dereference_protected(tp->ao_info,
+ lockdep_sock_is_held((struct sock *)tp));
+ if (ao) {
+ if (seq < ao->rcv_sne_seq)
+ ao->rcv_sne++;
+ ao->rcv_sne_seq = seq;
+ }
+#endif
WRITE_ONCE(tp->rcv_nxt, seq);
}
@@ -6369,6 +6393,17 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,
* simultaneous connect with crossed SYNs.
* Particularly, it can be connect to self.
*/
+#ifdef CONFIG_TCP_AO
+ struct tcp_ao_info *ao;
+
+ ao = rcu_dereference_protected(tp->ao_info,
+ lockdep_sock_is_held(sk));
+ if (ao) {
+ ao->risn = th->seq;
+ ao->rcv_sne = 0;
+ ao->rcv_sne_seq = ntohl(th->seq);
+ }
+#endif
tcp_set_state(sk, TCP_SYN_RECV);
if (tp->rx_opt.saw_tstamp) {
--
2.40.0
next prev parent reply other threads:[~2023-04-03 21:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 21:33 [PATCH v5 00/21] net/tcp: Add TCP-AO support Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Dmitry Safonov
2023-04-04 2:10 ` kernel test robot
2023-04-04 2:21 ` kernel test robot
2023-04-04 3:44 ` kernel test robot
2023-04-03 21:34 ` [PATCH v5 02/21] net/tcp: Add TCP-AO config and structures Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 03/21] net/tcp: Introduce TCP_AO setsockopt()s Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 04/21] net/tcp: Prevent TCP-MD5 with TCP-AO being set Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 05/21] net/tcp: Calculate TCP-AO traffic keys Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 06/21] net/tcp: Add TCP-AO sign to outgoing packets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 07/21] net/tcp: Add tcp_parse_auth_options() Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 08/21] net/tcp: Add AO sign to RST packets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk Dmitry Safonov
2023-04-04 2:00 ` kernel test robot
2023-04-03 21:34 ` [PATCH v5 10/21] net/tcp: Wire TCP-AO to request sockets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 11/21] net/tcp: Sign SYN-ACK segments with TCP-AO Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 12/21] net/tcp: Verify inbound TCP-AO signed segments Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 13/21] net/tcp: Add TCP-AO segments counters Dmitry Safonov
2023-04-03 21:34 ` Dmitry Safonov [this message]
2023-04-03 21:34 ` [PATCH v5 15/21] net/tcp: Add tcp_hash_fail() ratelimited logs Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 16/21] net/tcp: Ignore specific ICMPs for TCP-AO connections Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 17/21] net/tcp: Add option for TCP-AO to (not) hash header Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 18/21] net/tcp: Add TCP-AO getsockopt()s Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 19/21] net/tcp: Allow asynchronous delete for TCP-AO keys (MKTs) Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 20/21] net/tcp-ao: Add static_key for TCP-AO Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 21/21] net/tcp-ao: Wire up l3index to TCP-AO Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403213420.1576559-15-dima@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=cdleonard@gmail.com \
--cc=colona@arista.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fruggeri05@gmail.com \
--cc=fruggeri@arista.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox