* [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static
@ 2023-04-04 0:33 Tom Rix
2023-04-04 12:30 ` Wyes Karny
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tom Rix @ 2023-04-04 0:33 UTC (permalink / raw)
To: ray.huang, rafael, viresh.kumar; +Cc: linux-pm, linux-kernel, Tom Rix
smatch reports
drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
'mode_state_machine' was not declared. Should it be static?
This variable is only used in one file so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 6f4b8040d46c..5a3d4aa0f45a 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
return 0;
}
-cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
+static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
[AMD_PSTATE_DISABLE] = {
[AMD_PSTATE_DISABLE] = NULL,
[AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static
2023-04-04 0:33 [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static Tom Rix
@ 2023-04-04 12:30 ` Wyes Karny
2023-04-05 4:16 ` Dhruva Gole
2023-04-11 18:48 ` Rafael J. Wysocki
2 siblings, 0 replies; 4+ messages in thread
From: Wyes Karny @ 2023-04-04 12:30 UTC (permalink / raw)
To: Tom Rix; +Cc: ray.huang, rafael, viresh.kumar, linux-pm, linux-kernel
On 03 Apr 20:33, Tom Rix wrote:
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
> 'mode_state_machine' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Wyes Karny <wyes.karny@amd.com>
Tested-by: Wyes Karny <wyes.karny@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
> return 0;
> }
>
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> [AMD_PSTATE_DISABLE] = {
> [AMD_PSTATE_DISABLE] = NULL,
> [AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static
2023-04-04 0:33 [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static Tom Rix
2023-04-04 12:30 ` Wyes Karny
@ 2023-04-05 4:16 ` Dhruva Gole
2023-04-11 18:48 ` Rafael J. Wysocki
2 siblings, 0 replies; 4+ messages in thread
From: Dhruva Gole @ 2023-04-05 4:16 UTC (permalink / raw)
To: Tom Rix, ray.huang, rafael, viresh.kumar; +Cc: linux-pm, linux-kernel
On 04/04/23 06:03, Tom Rix wrote:
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
> 'mode_state_machine' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
You might want to use the Fixes: commit ("")
tag? It will help people to pick the patch while
back-porting fixes to older kernels.'
For example:
https://lore.kernel.org/all/20230403072443.83810-2-d-gole@ti.com/
Fixes: 0651a730924b ("gpio: davinci: Add support for system
suspend/resume PM")
Otherwise,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
> return 0;
> }
>
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> [AMD_PSTATE_DISABLE] = {
> [AMD_PSTATE_DISABLE] = NULL,
> [AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
--
Thanks and Regards,
Dhruva Gole
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static
2023-04-04 0:33 [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static Tom Rix
2023-04-04 12:30 ` Wyes Karny
2023-04-05 4:16 ` Dhruva Gole
@ 2023-04-11 18:48 ` Rafael J. Wysocki
2 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2023-04-11 18:48 UTC (permalink / raw)
To: Tom Rix; +Cc: ray.huang, rafael, viresh.kumar, linux-pm, linux-kernel
On Tue, Apr 4, 2023 at 2:33 AM Tom Rix <trix@redhat.com> wrote:
>
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
> 'mode_state_machine' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
> return 0;
> }
>
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> [AMD_PSTATE_DISABLE] = {
> [AMD_PSTATE_DISABLE] = NULL,
> [AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
> --
Applied as 6.4 material (under edited subject), thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-11 18:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 0:33 [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static Tom Rix
2023-04-04 12:30 ` Wyes Karny
2023-04-05 4:16 ` Dhruva Gole
2023-04-11 18:48 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox