* [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static
@ 2023-04-04 0:45 Tom Rix
2023-04-04 14:09 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-04 0:45 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-kernel, Tom Rix
smatch reports
drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
'mlxbf3_pmx_funcs' was not declared. Should it be static?
This variable is only used in one file so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/pinctrl/pinctrl-mlxbf3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c
index 3698f7bbd88d..d9944e6a0af9 100644
--- a/drivers/pinctrl/pinctrl-mlxbf3.c
+++ b/drivers/pinctrl/pinctrl-mlxbf3.c
@@ -159,7 +159,7 @@ static const struct pinctrl_ops mlxbf3_pinctrl_group_ops = {
static const char * const mlxbf3_gpiofunc_group_names[] = { "swctrl" };
static const char * const mlxbf3_hwfunc_group_names[] = { "hwctrl" };
-struct pinfunction mlxbf3_pmx_funcs[] = {
+static struct pinfunction mlxbf3_pmx_funcs[] = {
PINCTRL_PINFUNCTION("hwfunc", mlxbf3_hwfunc_group_names, 1),
PINCTRL_PINFUNCTION("gpiofunc", mlxbf3_gpiofunc_group_names, 1),
};
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static
2023-04-04 0:45 [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static Tom Rix
@ 2023-04-04 14:09 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-04-04 14:09 UTC (permalink / raw)
To: Tom Rix; +Cc: linux-gpio, linux-kernel
On Tue, Apr 4, 2023 at 2:45 AM Tom Rix <trix@redhat.com> wrote:
> smatch reports
> drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
> 'mlxbf3_pmx_funcs' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Obviously correct so patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-04 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 0:45 [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static Tom Rix
2023-04-04 14:09 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox