* [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static
@ 2023-04-04 1:01 Tom Rix
2023-04-05 23:59 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-04 1:01 UTC (permalink / raw)
To: seanjc, pbonzini, tglx, mingo, bp, dave.hansen, hpa
Cc: x86, kvm, linux-kernel, Tom Rix
smatch reports
arch/x86/kvm/x86.c:199:20: warning: symbol
'mitigate_smt_rsb' was not declared. Should it be static?
This variable is only used in one file so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8bb8f226f51f..4ce3411d35f3 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -196,7 +196,7 @@ bool __read_mostly eager_page_split = true;
module_param(eager_page_split, bool, 0644);
/* Enable/disable SMT_RSB bug mitigation */
-bool __read_mostly mitigate_smt_rsb;
+static bool __read_mostly mitigate_smt_rsb;
module_param(mitigate_smt_rsb, bool, 0444);
/*
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static
2023-04-04 1:01 [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static Tom Rix
@ 2023-04-05 23:59 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2023-04-05 23:59 UTC (permalink / raw)
To: Sean Christopherson, pbonzini, tglx, mingo, bp, dave.hansen, hpa,
Tom Rix
Cc: x86, kvm, linux-kernel
"varaiable" in the shortlog is mispelled, I just dropped it and wrapped the
variable name itself in quotes.
On Mon, 03 Apr 2023 21:01:41 -0400, Tom Rix wrote:
> smatch reports
> arch/x86/kvm/x86.c:199:20: warning: symbol
> 'mitigate_smt_rsb' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
>
> [...]
Applied to kvm-x86 misc, thanks!
[1/1] KVM: x86: set "mitigate_smt_rsb" storage-class-specifier to static
https://github.com/kvm-x86/linux/commit/944a8dad8b4e
--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-05 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 1:01 [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static Tom Rix
2023-04-05 23:59 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox