Re: [PATCH v3 3/9] media: dt-bindings: cadence-csi2rx: Convert to DT schema

Jack Zhu
2023-04-04T02:26:59Z

On 2023/4/3 17:53, Krzysztof Kozlowski wrote:
> On 03/04/2023 11:48, Jack Zhu wrote:
>>
>>
>> On 2023/4/1 4:12, Krzysztof Kozlowski wrote:
>>> On 31/03/2023 14:18, Jack Zhu wrote:
>>>> Convert DT bindings document for Cadence MIPI-CSI2 RX controller
>>>> to DT schema format.
>>>>
>>>> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
>>>> ---
>>>> .../devicetree/bindings/media/cdns,csi2rx.txt | 100 ----------
>>>> .../bindings/media/cdns,csi2rx.yaml | 174 ++++++++++++++++++
>>>> MAINTAINERS | 1 +
>>>> 3 files changed, 175 insertions(+), 100 deletions(-)
>>>> delete mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt
>>>> create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt b/Documentation/devicetree/bindings/media/cdns,csi2rx.txt
>>>> deleted file mode 100644
>>>> index 6b02a0657ad9..000000000000
>>>> --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.txt
>>>> +++ /dev/null
>>>> @@ -1,100 +0,0 @@
>>>> -Cadence MIPI-CSI2 RX controller
>>>> -===============================
>>>> -
>>>> -The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI
>>>> -lanes in input, and 4 different pixel streams in output.
>>>> -
>>>> -Required properties:
>>>> - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible
>>>
>>>
>>> ...
>>>
>>>> +$id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Cadence MIPI-CSI2 RX controller
>>>> +
>>>> +maintainers:
>>>> + - Maxime Ripard <mripard@kernel.org>
>>>> +
>>>> +description:
>>>> + The Cadence MIPI-CSI2 RX controller is a CSI-2 bridge supporting up to 4 CSI
>>>> + lanes in input, and 4 different pixel streams in output.
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + const: cdns,csi2rx
>>>
>>> That's not equivalent conversion and your commit msg does no mention any
>>> drops in compatibles.
>>>
>> The equivalent conversion refers to 'an SoC-specific compatible'?
>
> Yes.
>
>> I'm not sure that, is it enough to add a description (drop an 'SoC-specific compatible')
>> to my next version commit message?
>
> Original binding did not allow csi2rx compatible alone. Your binding
> here allows it, thus it is not simple conversion.
>
> I think patch 5 should be squashed here - with proper explanation.
> Usually new compatibles should not be messed with conversion, but this
> conversion on its own does not make much sense.
>
Ok, I will merge patch 5 into the patch, and add explanation in my
commit msg.
>
>
> Best regards,
> Krzysztof
>