Re: [PATCH 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

Laurent Pinchart
2023-04-05T04:02:11Z

Hi Geert,

Thank you for the patch.

On Fri, Mar 31, 2023 at 04:48:11PM +0200, Geert Uytterhoeven wrote:
> The LCD Controller supported by the drm-shmob driver is not only present
> on SuperH SH-Mobile SoCs, but also on Renesas ARM SH/R-Mobile SoCs.
> Make its option visible, so the user can enable support for it.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/gpu/drm/shmobile/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
> index 4ec5dc74a6b0b880..719d4e7a5cd75aad 100644
> --- a/drivers/gpu/drm/shmobile/Kconfig
> +++ b/drivers/gpu/drm/shmobile/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_SHMOBILE
> tristate "DRM Support for SH Mobile"
> depends on DRM && ARM

There shouldn't be anything ARM-dependent, could you drop "&& ARM" while
at it ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> - depends on ARCH_SHMOBILE || COMPILE_TEST
> + depends on ARCH_RENESAS || ARCH_SHMOBILE || COMPILE_TEST
> select BACKLIGHT_CLASS_DEVICE
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER

--
Regards,

Laurent Pinchart