Re: [PATCH v6 1/2] dt-bindings: omap: Convert omap.txt to yaml

Krzysztof Kozlowski
2023-04-06T08:36:45Z

On 06/04/2023 10:32, Krzysztof Kozlowski wrote:
> On 05/04/2023 18:19, Andreas Kemnade wrote:
>> From: Andrew Davis <afd@ti.com>
>>
>> Convert omap.txt to yaml.
>>
>
>
>> + - description: TI AM43 SoC based platforms
>> + items:
>> + - enum:
>> + - compulab,am437x-cm-t43
>> + - ti,am437x-gp-evm
>> + - ti,am437x-idk-evm
>> + - ti,am437x-sk-evm
>> + - pattern: '^ti,am4372[26789]$'
>> + - const: ti,am43
>> +
>> + - description: TI AM57 SoC based platforms
>> + items:
>> + - enum:
>> + - beagle,am5729-beagleboneai
>> + - compulab,cl-som-am57x
>> + - ti,am5718-idk
>> + - ti,am5728-idk
>> + - ti,am5748-idk
>> + - pattern: '^ti,am57[0124][689]$'
>
> I don't think my comments were resolved. I asked if it is possible to
> make a board called "ti,am5718-idk" with "ti,am5749" or with "ti,am5708"?

Hm, I cannot find my concern, so maybe it never left my outbox. Anyway,
it looks like you allow here many incorrect patterns and combinations.

>
> What's more, you dropped several variations and compatibles against
> original binding (all the "dra") and it is not explained in commit msg
> at all.

All changes against original bindings should be explained.

Best regards,
Krzysztof