From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D267EC7618D for ; Thu, 6 Apr 2023 10:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236634AbjDFKss (ORCPT ); Thu, 6 Apr 2023 06:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236625AbjDFKsj (ORCPT ); Thu, 6 Apr 2023 06:48:39 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8FBE4C39; Thu, 6 Apr 2023 03:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rdAbLYuDGVUm7ohyMR/0H/BoSxd4WAGt6zxSS/ncARs=; b=gTwWQys8gdM862G4qu6zi4JfXs 2DTw1Tztc/RBMvw6a4zPFgJOhVpnMODBIGWF2M7gIMZYncSBdmjZ2nBB7s+2Qb3OkoCaVlM3vnSOY mUComrjkVEv/lBzX4/FvMiV6U+jsiIFJSMU8APAKrv8Y4Xf3qrGZ3IW+ndEBMv16IznxPnJ9mJLNn IXBzvmveioLr0cBd82cPXjAY614plJ0Z9nSaUc/IEwmp5uMLa7gc1Rfxnj2WHaKpJAA1Z3vvtsthC zpfup66Pl0InbgqINg5srbd75TR3p7/axh6RkKG4SoG9QVX3o5SrmEPCxizAMn4bWE2cQYWgw1kJz UDbARO8A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkN9n-00HL0u-Cd; Thu, 06 Apr 2023 10:47:55 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 0C92A300194; Thu, 6 Apr 2023 12:47:50 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D27AE207C33EE; Thu, 6 Apr 2023 12:47:50 +0200 (CEST) Date: Thu, 6 Apr 2023 12:47:50 +0200 From: Peter Zijlstra To: Jiri Slaby Cc: Paolo Bonzini , Lai Jiangshan , Dave Hansen , linux-kernel@vger.kernel.org, Lai Jiangshan , "H. Peter Anvin" , Andi Kleen , Andrew Cooper , Andy Lutomirski , Asit Mallick , Cfir Cohen , Dan Williams , David Kaplan , David Rientjes , Erdem Aktas , Jan Kiszka , Joerg Roedel , Juergen Gross , Kees Cook , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Linus Torvalds , Mike Stunes , Raj Ashok , Sean Christopherson , Thomas Gleixner , Tom Lendacky , Tony Luck , kvm@vger.kernel.org, linux-coco@lists.linux.dev, x86@kernel.org Subject: Re: [RFC PATCH 0/7] x86/entry: Atomic statck switching for IST Message-ID: <20230406104750.GA392176@hirez.programming.kicks-ass.net> References: <20230403140605.540512-1-jiangshanlai@gmail.com> <19035c40-e756-6efd-1c02-b09109fb44c1@intel.com> <3591487f-96ae-3ab7-6ce7-e524a070c9e7@redhat.com> <20230406101254.GI386572@hirez.programming.kicks-ass.net> <26be2c81-9431-6b43-e3e9-52d7d184750e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26be2c81-9431-6b43-e3e9-52d7d184750e@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2023 at 12:35:24PM +0200, Jiri Slaby wrote: > On 06. 04. 23, 12:12, Peter Zijlstra wrote: > > On Tue, Apr 04, 2023 at 07:03:45PM +0200, Paolo Bonzini wrote: > > > On 4/4/23 05:17, Lai Jiangshan wrote: > > > > The cover letter has 800+ lines of comments. About 100-300 lines > > > > of comments will be moved into the code which would make the diffstat > > > > not so appealing. > > > > > > Removing assembly from arch/x86/entry/ and adding English to Documentation/? > > > That's _even more_ appealing. :) > > > > I *much* prefer in-code comments to random gibberish that's instantly > > out of date squirreled away somewhere in an unreadable format in > > Documentation/ > > +1 as one can link comments in the code to Documentation easily nowadays. > They are sourced and end up in the generated Documentation [1] then. One > only needs to type the kernel-doc properly. Urgh, so that kernel doc stuff can defeat its purpose too. Some of that is so heavily formatted it is unreadable gibberish just like Documentation/ :/ I really detest that whole RST thing, and my solution is to explicitly not write kerneldoc, that way the doc generation stuff doesn't complain and I don't get random drive by patches wrecking the perfectly readable comment.