From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84116C7618D for ; Thu, 6 Apr 2023 11:37:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237973AbjDFLg7 (ORCPT ); Thu, 6 Apr 2023 07:36:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238345AbjDFLfy (ORCPT ); Thu, 6 Apr 2023 07:35:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD381A256; Thu, 6 Apr 2023 04:33:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70FDA6446F; Thu, 6 Apr 2023 11:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECA27C4339B; Thu, 6 Apr 2023 11:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780836; bh=wR25MoF7TqcSV4qPjt5hyhxkfE7t1ZhmPlEB8TFCcC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tq2kfaF7aT5MZ3VnhnmB5BYKxRRKaUVU7EOiK0M45hkJuhitU1nmtW9Pk9bytGzmi vvXroYIUnYb7ktGZhMMDm7o79AoFDT6zVWvIb9pYyB5zpdRhwY270/e3F6J2DqRO4d 3Oeu7A/9JgJuldqk6PG16295VQM7o0mfZpY5uYZ4KcFXnx4mnpPCf2NaQuo+55GC8F WKhAQUESNVAuULjxXb9RNs1IEjb8n998S+LV/GfQ5a9OKkfS8hJk83dMRIViqdwQ3/ mI8c5VX9VB3sC1FoU8nfEBB126Ffko/82Gawh5q/L+GLbM3MlJ1uqnrx3Nna0TQP+Z JfjtCiLD4+QFA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Heiko Carstens , Sven Schnelle , Vasily Gorbik , Sasha Levin , oleg@redhat.com, agordeev@linux.ibm.com, linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 7/9] s390/ptrace: fix PTRACE_GET_LAST_BREAK error handling Date: Thu, 6 Apr 2023 07:33:35 -0400 Message-Id: <20230406113337.648916-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113337.648916-1-sashal@kernel.org> References: <20230406113337.648916-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiko Carstens [ Upstream commit f9bbf25e7b2b74b52b2f269216a92657774f239c ] Return -EFAULT if put_user() for the PTRACE_GET_LAST_BREAK request fails, instead of silently ignoring it. Reviewed-by: Sven Schnelle Signed-off-by: Heiko Carstens Signed-off-by: Vasily Gorbik Signed-off-by: Sasha Levin --- arch/s390/kernel/ptrace.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/s390/kernel/ptrace.c b/arch/s390/kernel/ptrace.c index ad74472ce967e..34ca344039bbf 100644 --- a/arch/s390/kernel/ptrace.c +++ b/arch/s390/kernel/ptrace.c @@ -502,9 +502,7 @@ long arch_ptrace(struct task_struct *child, long request, } return 0; case PTRACE_GET_LAST_BREAK: - put_user(child->thread.last_break, - (unsigned long __user *) data); - return 0; + return put_user(child->thread.last_break, (unsigned long __user *)data); case PTRACE_ENABLE_TE: if (!MACHINE_HAS_TE) return -EIO; @@ -856,9 +854,7 @@ long compat_arch_ptrace(struct task_struct *child, compat_long_t request, } return 0; case PTRACE_GET_LAST_BREAK: - put_user(child->thread.last_break, - (unsigned int __user *) data); - return 0; + return put_user(child->thread.last_break, (unsigned int __user *)data); } return compat_ptrace_request(child, request, addr, data); } -- 2.39.2