Re: [PATCH v2 02/19] arch/arc: Implement with generic helpers

Thomas Zimmermann
2023-04-17T09:04:51Z

[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]

Am 06.04.23 um 16:43 schrieb Arnd Bergmann:
> On Thu, Apr 6, 2023, at 16:30, Thomas Zimmermann wrote:
>> +
>> static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma,
>> unsigned long off)
>> {
>> vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
>> }
>> +#define fb_pgprotect fb_pgprotect
>
> I still feel that for architectures like arc that don't have
> pgprot_writecombine(), it would b best to go with the
> generic implementation that currently behaves the exact
> same way. If pgprot_writecombine() gets added in the future,
> it would cause the architecture to behave as expected rather
> than introducing the same bug that mips has.

OK, I'll change it.

>
> Arnd

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]