Re: [PATCH v2 2/2] dt-bindings: cisco: document the CrayAR compatibles

["Daniel Walker (danielwa)" <danielwa@cisco.com>]

On Thu, Apr 06, 2023 at 06:50:53PM +0200, Krzysztof Kozlowski wrote:
> On 06/04/2023 17:15, Daniel Walker (danielwa) wrote:
> > On Thu, Apr 06, 2023 at 09:12:34AM +0200, Krzysztof Kozlowski wrote:
> >> On 06/04/2023 00:30, Daniel Walker wrote:
> >>> Describe the compatible properties for the Cisco CrayAR SoC.
> >>>
> >>> Cc: xe-linux-external@cisco.com
> >>> Cc: Marcin Wierzbicki <mawierzb@cisco.com>
> >>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> Cc: Rob Herring <robh+dt@kernel.org>
> >>
> >> Please drop the autogenerated scripts/get_maintainer.pl CC-entries from
> >> commit msg. There is no single need to store automated output of
> >> get_maintainers.pl in the git log. It can be easily re-created at any
> >> given time, thus its presence in the git history is redundant and
> >> obfuscates the log.
> >>
> >> If you need it for your own patch management purposes, keep it under the
> >> --- separator.
> >  
> > I added these, so it's not script output. I can move them under the separator.
> > The reason for that was to make sure people who commented get Cc'd.
> 
> So read my message again. There is no reason to add these entries for
> people who are listed as maintainers, because you are supposed to CC
> maintainers always.
 
Maintainers change over time.. I'd rather not have to keep track of who the
maintainers are at any given time.

I won't delete this, but I offered to move it under the separator.

> > 
> >>> Signed-off-by: Daniel Walker <dwalker@fifo99.com>
> >>> ---
> >>>  .../devicetree/bindings/arm/cisco/crayar.yaml | 27 +++++++++++++++++++
> >>>  1 file changed, 27 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/arm/cisco/crayar.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/cisco/crayar.yaml b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml
> >>> new file mode 100644
> >>> index 000000000000..0ee4e6313ab0
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/arm/cisco/crayar.yaml
> >>
> >> How many (or not many) platforms do you expect from Cisco? We mostly
> >> have one file per SoC manufacturer.
> > 
> > We have two SoC's one called CrayAR and another called Craw. I've submitted the
> > Craw dts file before , but I've not resubmitted it. Under Craw I think we have
> > at least two, but more likely five variations. CrayAR we have one variation with
> > at least one more planned.
> > 
> > So we would plan over time to add two dtsi files and three to four dts files to
> > this directory. Then more over time.
> 
> So just keep them in one file maybe.

If/when I submit again with anther chip we can discuss it at that time.

Daniel